feat(species): restrict species management to super admins - #1223
Open
mienpham04 wants to merge 1 commit into
Open
feat(species): restrict species management to super admins#1223mienpham04 wants to merge 1 commit into
mienpham04 wants to merge 1 commit into
Conversation
…tions Gate the /species route to super admins only via a new isSuperAdmin() helper (checks the global SUPER_PERMISSION policy and no organization scope), so add, edit and delete are limited to super admins. Route-level access is enforced through the disabled flag in Routers. Also expose loadSpeciesList() from SpeciesContext so add/edit/delete/ combine reload the table after a mutation. The query is disabled by default, so invalidateQueries alone won't refetch it; the missing function previously left the delete/edit dialogs open and unrefreshed.
|
Does that include Keycloak as the permission system? |
Author
|
@sebastiangaertner no, this doesn't use Keycloak |
|
@dadiorchen do we manage super admin user rights in the admin panel or will this also be handled by keycloak? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gate the /species route to super admins only via a new isSuperAdmin() helper (checks the global SUPER_PERMISSION policy and no organization scope), so add, edit and delete are limited to super admins. Route-level access is enforced through the disabled flag in Routers.
Also expose loadSpeciesList() from SpeciesContext so add/edit/delete/ combine reload the table after a mutation. The query is disabled by default, so invalidateQueries alone won't refetch it; the missing function previously left the delete/edit dialogs open and unrefreshed.
Description
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
What is the new behavior?
Breaking change
Does this PR introduce a breaking change?
No
Other useful information