fix(verify): handle invalid capture filter errors - #1224
Open
harshgupta6789 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue(s) addressed
Prevent invalid alphanumeric Capture ID and Grower ID filters from submitting
Clear loading state when capture list/count requests fail
Apply the same error handling to Verify capture loading/count requests
Resolves Verify: The captures hang when an error happens. #936
What kind of change(s) does this PR introduce?
Issue
Current behaviour: Submitting invalid alphanumeric values in the Capture ID or Grower ID filters can cause the captures/verify pages to stay stuck on a loading spinner when the API returns an error.
New behaviour: Invalid Capture ID and Grower ID filter values are validated before submitting. API errors while loading captures or capture counts are also handled so the loading spinner is cleared and the page does not hang.
Breaking change
No