fix(verify): restrict verify tool access to approve_tree and super_pe… - #1230
Open
yasiru98 wants to merge 1 commit into
Open
fix(verify): restrict verify tool access to approve_tree and super_pe…#1230yasiru98 wants to merge 1 commit into
yasiru98 wants to merge 1 commit into
Conversation
…rmission policies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
list_treepolicy could access the Verify tool.AppContext.js, thehasPermissioncheck for the Verify route includedPOLICIES.LIST_TREEalongsidePOLICIES.SUPER_PERMISSIONandPOLICIES.APPROVE_TREE. SincehasPermissionreturnstrueif the user has at least one of the listed policies,list_treealone was sufficient to gain access.POLICIES.LIST_TREEfrom the Verify route permission check so only users withapprove_treeorsuper_permissioncan access the tool.Issue(s) addressed
approve_treeorsuper_permissionpolicies #818What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
Users with only the
list_treepolicy can access the Verify tool. The Verify tool should be restricted to users withapprove_treeorsuper_permissionpolicies only.What is the new behavior?
Only users with
approve_treeorsuper_permissionpolicies can access the Verify tool. Users with onlylist_treeare shown the Unauthorized page.Breaking change
Does this PR introduce a breaking change?
No.
Other useful information