fix: drop manifest screenOrientation portrait (#1171) - #1227
fix: drop manifest screenOrientation portrait (#1171)#1227pradhyumna186 wants to merge 1 commit into
Conversation
…nd ImageCaptureActivity to satisfy Google Play large-screen resizability/orientation requirements (Android 16+).
|
As mentioned in the related issue, this will not be merged until we have proper support for landscape. |
|
I will work on it |
|
Hi, I'm Shivani from the Greenstand design team. I'd like to work on the landscape UI designs for this PR. Happy to be assigned! |
|
Hi @shivanipednekar87-cloud, please talk with Yuri through Slack. She's doing a lot of design work lately. @pradhyumna186 we'll want designs before work on landscape starts |
|
@shivanipednekar87-cloud , is there any progress here? |
|
@tosinolarinde please proceed to work on the design for this. |
|
@Elforama @tosinolarinde completed the landscape designs: https://www.figma.com/design/1vVataT9HKeZSH9EU8G7H6/Greenstand?node-id=0-1&t=0uE3NuornZMSn238-1 |
|
We should not be designing for the current UI. There will be a UI refresh. We should do it then. |
|
👋 Hi @pradhyumna186, thanks for the contribution! Before this PR can be reviewed and merged, please add:
Just drag-and-drop the file(s) into the PR description and GitHub will upload them. This check re-runs automatically when you edit the description. If this change has no user-visible effect, tick the "no user-visible / UI effect" box in the description (or ask a maintainer to add the |
|
I have the landscape design. I will start working on it @cynthiabondi |
|
@pradhyumna186 please discuss with @Elforama first as he mentioned there will be a UI refresh |
|
okay @cynthiabondi I will wait on @Elforama for confimation |
Summary
Removes manifest
android:screenOrientation="portrait"fromTreeTrackerActivityandImageCaptureActivityso the app no longer declares orientation locks that conflict with Google Play guidance for large screens and Android 16+ behavior. Previous values are preserved as XML comments with context (seeAndroidManifest.xml).Fixes #1171
Checklist
./codeAnalysis(formatting + lint).Verification (please review)
Short screen recording attached showing the app rotating between portrait and landscape on a Resizable emulator to see current behavior after removing the manifest lock.
Landscape / large-screen notes (future work, not blocking this PR):
Screen_recording_20260403_102559.webm
Screen_recording_20260403_102535.webm
Screen_recording_20260403_102627.webm
Notes