feat:Hook firebase remote config org fetch into sync and smart startup - #1279
feat:Hook firebase remote config org fetch into sync and smart startup#1279jaycenusa wants to merge 17 commits into
Conversation
Elforama
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left some feedback to be addressed.
…to feat/issue-1262-hook-firebase-conf
…nusa/treetracker-android into feat/issue-1262-hook-firebase-conf
Elforama
left a comment
There was a problem hiding this comment.
I've updated the issue to be more clear. I hope things make a bit more sense now.
So this needs to sync one time on startup, and every time when the sync process happens.
| Timber.tag(ORG_LINK_TAG).i("Deeplink received: orgId=$orgId, orgName=$orgName") | ||
| val configJson = orgConfigProvider.fetchOrgConfig(orgId) | ||
| if (configJson != null) { | ||
| // Non-deeplink launch: refresh current org config if we haven't yet |
There was a problem hiding this comment.
this is actually a deeplink launch.
|
👋 Hi @jaycenusa, thanks for the contribution! Before this PR can be reviewed and merged, please add:
Just drag-and-drop the file(s) into the PR description and GitHub will upload them. This check re-runs automatically when you edit the description. If this change has no user-visible effect, tick the "no user-visible / UI effect" box in the description (or ask a maintainer to add the |
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
./codeAnalysisto automatically apply formatting/linting)Fixes #1262 🦕
Files change:
Unit test files: