Skip to content

feat:Hook firebase remote config org fetch into sync and smart startup - #1279

Open
jaycenusa wants to merge 17 commits into
Greenstand:masterfrom
jaycenusa:feat/issue-1262-hook-firebase-conf
Open

feat:Hook firebase remote config org fetch into sync and smart startup#1279
jaycenusa wants to merge 17 commits into
Greenstand:masterfrom
jaycenusa:feat/issue-1262-hook-firebase-conf

Conversation

@jaycenusa

@jaycenusa jaycenusa commented May 6, 2026

Copy link
Copy Markdown
Contributor

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #1262 🦕

Files change:

  • app/.../di/AppModule.kt
  • app/.../splash/SplashScreenViewModel.kt
  • app/.../models/organization/OrgRepo.kt

Unit test files:

  • app/.../test/../splash/SplashScreenViewModelTest.kt
  • app/.../test/../usecases/SyncDataUseCaseTest.kt

@cynthiabondi
cynthiabondi requested a review from Elforama May 7, 2026 06:44

@Elforama Elforama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some feedback to be addressed.

Comment thread app/src/main/java/org/greenstand/android/TreeTracker/usecases/SyncDataUseCase.kt Outdated
@cynthiabondi cynthiabondi moved this to Ready for Review in Android Treetracker May 12, 2026
@Elforama Elforama added 2.3 and removed 2.2.1 labels May 19, 2026
@jaycenusa
jaycenusa changed the base branch from master to release-2.1.1 May 20, 2026 12:25
@jaycenusa
jaycenusa changed the base branch from release-2.1.1 to master May 20, 2026 12:33
@jaycenusa
jaycenusa requested a review from Elforama May 20, 2026 21:21

@Elforama Elforama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the issue to be more clear. I hope things make a bit more sense now.

So this needs to sync one time on startup, and every time when the sync process happens.

Timber.tag(ORG_LINK_TAG).i("Deeplink received: orgId=$orgId, orgName=$orgName")
val configJson = orgConfigProvider.fetchOrgConfig(orgId)
if (configJson != null) {
// Non-deeplink launch: refresh current org config if we haven't yet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actually a deeplink launch.

@github-actions

Copy link
Copy Markdown

👋 Hi @jaycenusa, thanks for the contribution!

Before this PR can be reviewed and merged, please add:

  • a 🎥 screen recording / video demonstrating the change — a video is required even when there are no UI changes, to show that the parts of the app affected by this change still work
  • a 🖼️ screenshot of the UI change (or mark the PR as non-ui if there is no UI change)

Just drag-and-drop the file(s) into the PR description and GitHub will upload them. This check re-runs automatically when you edit the description.

If this change has no user-visible effect, tick the "no user-visible / UI effect" box in the description (or ask a maintainer to add the non-ui label) to skip the screenshot requirement. A video is still required even with no UI changes, to show that the affected parts of the app still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

Hook Firebase Remote Config org fetch into sync and smart startup

3 participants