Skip to content

refactor: split AppModule DI definitions into focused modules - #1283

Open
aneepal55 wants to merge 3 commits into
Greenstand:masterfrom
aneepal55:Split_AppModuleDI_configuration
Open

refactor: split AppModule DI definitions into focused modules#1283
aneepal55 wants to merge 3 commits into
Greenstand:masterfrom
aneepal55:Split_AppModuleDI_configuration

Conversation

@aneepal55

@aneepal55 aneepal55 commented May 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests are added/updated (if necessary)
  • Ensure the linter passes (./codeAnalysis to automatically apply formatting/linting)
  • Appropriate docs were updated (if necessary)

Fixes #1240 🦕

@Elforama

Elforama commented May 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! Please share a video going through the app screens to ensure nothing crashes.

@github-actions

Copy link
Copy Markdown

👋 Hi @aneepal55, thanks for the contribution!

Before this PR can be reviewed and merged, please add:

  • a 🎥 screen recording / video demonstrating the change — a video is required even when there are no UI changes, to show that the parts of the app affected by this change still work
  • a 🖼️ screenshot of the UI change (or mark the PR as non-ui if there is no UI change)

Just drag-and-drop the file(s) into the PR description and GitHub will upload them. This check re-runs automatically when you edit the description.

If this change has no user-visible effect, tick the "no user-visible / UI effect" box in the description (or ask a maintainer to add the non-ui label) to skip the screenshot requirement. A video is still required even with no UI changes, to show that the affected parts of the app still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

Split AppModule.kt DI configuration by feature (269 lines)

3 participants