feat: update some interceptor to carry more information#8090
Draft
sunng87 wants to merge 9 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors QueryContext to consolidate mutable fields—including extensions, snapshot sequences, and SST minimum sequences—into a single RwLock protected structure, thereby removing redundant Arc wrapping. The interceptor API was updated, specifically modifying pre_execute to accept optional statements and adding PromQL expression support to PromQueryInterceptor. Additionally, the changes incorporate performance optimizations by utilizing unwrap_or_else for lazy string allocations and cleaning up unnecessary string conversions and mutable variable declarations throughout the codebase. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Exprtopre_executeOption<&Statement>to SqlQueryInterceptorPR Checklist
Please convert it to a draft if some of the following conditions are not met.