Skip to content

refactor: optimize json2 write#8393

Draft
MichaelScofield wants to merge 3 commits into
mainfrom
refactor/optimize-json2-write
Draft

refactor: optimize json2 write#8393
MichaelScofield wants to merge 3 commits into
mainfrom
refactor/optimize-json2-write

Conversation

@MichaelScofield

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
@github-actions github-actions Bot added size/M docs-not-required This change does not impact docs. labels Jul 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the conversion of JSON values into struct vectors by introducing schema-aware conversion helpers (json_variant_to_struct_value_ref and json_variant_to_value_ref) and removing the as_value_ref method from JsonValueRef. It also adds a push_struct_value_ref method to StructVectorBuilder to push struct value references directly, and updates the pipeline transformer to resolve schemas using ConcreteDataType::json2. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant