refactor: optimize json2 write#8393
Conversation
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
Signed-off-by: luofucong <luofc@foxmail.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the conversion of JSON values into struct vectors by introducing schema-aware conversion helpers (json_variant_to_struct_value_ref and json_variant_to_value_ref) and removing the as_value_ref method from JsonValueRef. It also adds a push_struct_value_ref method to StructVectorBuilder to push struct value references directly, and updates the pipeline transformer to resolve schemas using ConcreteDataType::json2. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.