Small things #707
Merged
Small things #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcsantos-gpa
force-pushed
the
Small_things
branch
from
3a4d80e to
88ecccb
Compare
|
I tested this, and when console text comes in, it pushes the command entry box down so you have to scroll the whole modal to see not only the bottom of the console window, but also the command entry box. |
gcsantos-gpa
force-pushed
the
Small_things
branch
from
a9586c6 to
40c8b33
Compare
Nice catch! I fixed this and I also found another bug that was fixed in testing where sometimes sending commands wouldn't work due to some react weirdness on state updating within functions. |
elwills
approved these changes
Jun 11, 2025
…s not making it into function definitions, switching to a ref allows it to always make it and also is a performance gain since we don't rerender for it either
gcsantos-gpa
force-pushed
the
Small_things
branch
from
40c8b33 to
24f2296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue(s)
SC-244, SC-248
Description
UI issues and modal code clean up as per tickets.