fix: derive cover art width from row height for 600x800 source aspect - #44
Merged
GuiDev1994 merged 1 commit intoJul 20, 2026
Merged
Conversation
GuiDev1994
approved these changes
Jul 20, 2026
GuiDev1994
left a comment
GuiDev1994
left a comment
Owner
There was a problem hiding this comment.
Approved and included in #51 (Release v1.1.4).
Owner
|
Included in Aurora v1.1.4 via #. Thank you @KrisEnigma — credited in the README Contributors section and preserved in git history on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short, boxart has more horizontal spacing, with proper aspect ratio for containers.
Cover art border was being stretched into roughly square grid cells, distorting the container. Fixed by deriving cell width from row height instead of the reverse, so cells match the source aspect ratio while keeping the same row height as before. Columns are equal-fr tracks in lv_gridview with LV_GRID_ALIGN_CENTER, so the now-narrower cells auto-center -- which is also what gives the extra horizontal spacing, no separate gap tweak needed. Standalone, based on upstream/main.