fix: stop game grid cover art flickering on every poll - #47
Merged
GuiDev1994 merged 1 commit intoJul 20, 2026
Merged
Conversation
apps_list_detect_change() always returned a NULL changes pointer, even when it determined the list was identical (num_changes=0). lv_gridview_set_data_advanced() treats changes==NULL as 'invalidate everything' regardless of num_changes, so every single poll -- even ones where nothing changed -- fully recycled and rebuilt every visible tile. Compounding this, appitem_bind() unconditionally called coverloader_display() on every rebind, restarting the cover art load even when the tile was already showing the correct app. Together these caused a visible flicker on every ~10s poll. Fixed by having apps_list_detect_change() return a non-NULL (if empty) sentinel whenever num_changes=0, so the widget skips the unnecessary full rebuild, and by skipping coverloader_display() in appitem_bind() when the view is already displaying the right app's cover. Confirmed via git history and a live fetch of mariotaku/moonlight-tv's current source that both of these are latent bugs shared with upstream, not something introduced by this fork.
GuiDev1994
approved these changes
Jul 20, 2026
GuiDev1994
left a comment
GuiDev1994
left a comment
Owner
There was a problem hiding this comment.
Approved and included in #51 (Release v1.1.4).
Owner
|
Included in Aurora v1.1.4 via #. Thank you @KrisEnigma — credited in the README Contributors section and preserved in git history on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short, the app selection flickered every 10 seconds, this fixes it.
apps_list_detect_change() always returned a NULL changes pointer, even when it determined the list was identical (num_changes=0). lv_gridview_set_data_advanced() treats changes==NULL as 'invalidate everything' regardless of num_changes, so every single poll -- even ones where nothing changed -- fully recycled and rebuilt every visible tile. Compounding this, appitem_bind() unconditionally called coverloader_display() on every rebind, restarting the cover art load even when the tile was already showing the correct app. Together these caused a visible flicker on every ~10s poll.
Fixed by having apps_list_detect_change() return a non-NULL (if empty) sentinel whenever num_changes=0, so the widget skips the unnecessary full rebuild, and by skipping coverloader_display() in appitem_bind() when the view is already displaying the right app's cover.
Confirmed via git history and a live fetch of mariotaku/moonlight-tv's current source that both of these are latent bugs shared with upstream, not something introduced by this fork.
Touches apps.controller.c, same file as the focus-preservation PR (not git-stacked, but overlapping) -- recommend merging one before the other to avoid a conflict.