fix: stop settings checkboxes double-toggling on remote OK press - #48
Merged
GuiDev1994 merged 1 commit intoJul 20, 2026
Merged
Conversation
LVGL's keypad handling already synthesizes a CLICKED event after an ENTER key release for the focused object (indev_keypad_proc in lv_indev.c). pref_checkable_activate() and idr_checkbox_activate() were also listening on LV_EVENT_KEY for ENTER, so a single remote OK press fired the toggle twice, visually canceling out. Drop the redundant LV_EVENT_KEY registration/handling; CLICKED alone covers touch and remote/keypad activation.
GuiDev1994
approved these changes
Jul 20, 2026
GuiDev1994
left a comment
GuiDev1994
left a comment
Owner
There was a problem hiding this comment.
Approved and included in #51 (Release v1.1.4).
Owner
|
Included in Aurora v1.1.4 via #. Thank you @KrisEnigma — credited in the README Contributors section and preserved in git history on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short, pressing "enter" on checkboxes works properly now instead of "double clicking".
LVGL's keypad handling already synthesizes a CLICKED event after an ENTER key release for the focused object (indev_keypad_proc in lv_indev.c). pref_checkable_activate() and idr_checkbox_activate() were also listening on LV_EVENT_KEY for ENTER, so a single remote OK press fired the toggle twice, visually canceling out. Drops the redundant LV_EVENT_KEY registration/handling; CLICKED alone covers touch and remote/keypad activation. Standalone, based on upstream/main.