Fix conditional sections failing when using command line arguments #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onditional sections are enabled Fixes bug when arguments are given with command line arguments when conditional sections are enabled. When `param.section.is_enabled` is being checked in `config.augment_argparse()` the sections have not yet been initialized and so all the conditional sections will fail the check even if the conditions are true, when the parameters are passed through command line arguments. Check for conditional section is already being done in `config.__getitem__()` when `config.collect()` is called. So no need to check it in `config.augment_argparse()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug when arguments are given with command line arguments when conditional sections are enabled.
When
param.section.is_enabledis being checked inconfig.augment_argparse()the sections have not yet been initialized and so all the conditional sections will fail the check even if the conditions are true, when the parameters are passed through command line arguments. Check for conditional section is already being done inconfig.__getitem__()whenconfig.collect()is called. So no need to check it inconfig.augment_argparse().