deps(librespot): bump librespot to pre 0.8.0 #56
+925
−742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the recent changes released by Spotify no metadata retrieval is possible. `librespot` 0.7.1 adds these needed changes.
Due to the recent changes released by Spotify librespot dev branch have been updated but since that branch have some breaking changes, spotify-dl have to also be updated (see track.rs)
|
I was about to write that you have a borrow issue. I had an old state. |
royvandam
reviewed
Dec 22, 2025
| structopt = { version = "0.3", default-features = false } | ||
| indicatif = "0.18" | ||
| librespot = { version = "0.6.0", default-features = false } | ||
| librespot = { version = "0.8.0" } |
There was a problem hiding this comment.
In order to keep librespot’s dependency set small, I suggest keeping default-features = false and explicitly selecting the TLS backend, as the build error suggests when it’s not set. If we don’t, librespot pulls in extra audio playback dependencies such as ALSA.
Suggested change
| librespot = { version = "0.8.0" } | |
| librespot = { version = "0.8.0", default-features = false, features = ["rustls-tls-native-roots"] } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the recent changes released by Spotify, metadata retreival was failing,
so downloads. Through librespot fix #1622
librespot dev branch (pre 0.8.0) have been updated.
But since that dev branch have introduced some breaking changes, spotify-dl
have to also be updated (see track.rs)