improve the way we terminate subprocess during test runs#7
Merged
GustavoCaso merged 2 commits intomainfrom Aug 21, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our test we are leaving lingering processes after completing.
t.Contextwhen usingrunCliCommandsometimes failed to execute the command because of the context being cancelled. This was particular hapenning on ourCleanupfunction for our server.TestRunCommand_Foreground. Looks like our tests creates a many processes:go test,go run .so when sending the SIGTERM togo run .command we still have a process left after the test.We fixed by creating a process group associated with the
go run .command, so all sub processes created can be terminated usingsyscall.Kill(-cmd.Process.Pid, syscall.SIGTERM)