chore: move all non adapter components out of UI #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serikjensen
force-pushed
the
chore/GWS-5004
branch
from
c67143a to
8b23051
Compare
jeffredodd
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some components when we first started adapter work that were placed in the
UIdirectory that don't have adapters. For consistency, we should only have components in the UI directory that have corresponding adapters. If they do not have adapters, they can just live in theCommondirectory with our other components for general use.This is because we have special linting rules for the UI directory, but there's really no reason to add those restrictions to non adapter components.
This moves all non adapter components in
UIto the parentCommondirectory.All moved UI elements building in ladle as expected
This was primarily comprised of fieldset, field layout, and associated form utilities