Open PCAP files from Linux and Windows file managers - #1289
Open
SR0725 wants to merge 1 commit into
Open
Conversation
SR0725
force-pushed
the
fix/pcap-file-associations
branch
from
August 27, 2026 19:20
15a8bac to
cbf22e7
Compare
Owner
|
Hey @SR0725 thank you! Nice to see that implementing support for this is quite simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This connects file-manager "Open with" actions to Sniffnet's existing PCAP import flow on Linux and Windows.
Changes:
application/vnd.tcpdump.pcapin the Linux desktop entry.pcap,.pcapng, and.capin the Windows MSI--adapterstartup path and reject conflicting capture sourcesmacOS is not included in this change. The current app bundle starts through a shell wrapper, while Launch Services delivers an open-document event instead of a file argument. Supporting that path needs a native event bridge rather than another file-association entry.
Verification:
cargo test— 232 passedcargo clippy -- -D warningscargo fmt --all -- --checkcargo run -- --helpxmllint --noout resources/packaging/windows/setup.wxsI could not build the Windows MSI locally from macOS, so the Windows packaging job remains the platform-specific validation for that part.
AI assistance: I used an AI coding assistant while investigating and implementing this change. I reviewed the diff and can explain each change.
Related to #1288.