Convert RT light color to sRGB #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good to me. For my reference, could you make an image similar to the one labelled "Plasma with the fix" that shows the current in-game behavior so we can have a good before/after comparison? |
Collaborator
Author
|
Yep, here it is. After. |
Member
|
Oh, yeah, that's a huge improvement. |
Hoikas
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described on discord the other day. Realtime light color must be converted to sRGB, otherwise they will be much darker than in Blender and suffer from hue shift/oversaturation.
This is still not perfect. Maybe because Blender does all light calculation in linear space, whereas Plasma likely doesn't - or maybe there's still something else that I have missed. But at least it's much closer now.
Animated light color may still be slightly incorrect if the interpolation is done in the wrong color space. Not much that can be done without adding more keyframes.
Blender:
Plasma with fix (notice the middle row is still not as bright as it should be):
Test file:
LightTest.zip
Ages exported with previous versions of Korman will likely see their realtime lighting be brighter, and manual adjustment will be necessary.