Skip to content

feat: add QR code upload to Additional Information section#7

Closed
komposter wants to merge 1 commit into
H1D:mainfrom
komposter:feature/qr-code-upload
Closed

feat: add QR code upload to Additional Information section#7
komposter wants to merge 1 commit into
H1D:mainfrom
komposter:feature/qr-code-upload

Conversation

@komposter

@komposter komposter commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds the ability to upload a payment QR code image in the Additional Information section of the invoice form. The uploaded QR code will be displayed directly below the payment totals in the generated PDF.

Changes

  • Added a file input for QR codes in index.html.
  • Updated InvoiceData in types.ts to include qrCode.
  • Implemented localStorage persistence for the QR code in storage.ts.
  • Wired up image validation and preview logic in app.ts.
  • Implemented rendering logic in pdf-generator.ts to draw the QR code beside the payment totals section.
  • Explicitly excluded the QR code from the shared invoice URL to avoid exceeding URL length limits, along with a warning toast message.
  • Added e2e tests for QR code preview default state and share URL warning logic.

Deploy Preview: https://69ecf7c343cd26c3af4608fd--easypdf-lite.netlify.app/

Prefilled test links:

chore: build frontend before serving

feat: show QR near total and omit from shared links

fix: keep totals under To pay when QR is present

chore: revert project tooling changes
@H1D

H1D commented Apr 25, 2026

Copy link
Copy Markdown
Owner

@komposter nice idea... But I don't like QRs being persisted into localstorage... Kinda beats whole idea of URL pre-filled form.

I'll create a similar version where you provide payment URL and QR gets generated automatically.

@H1D H1D closed this Apr 25, 2026
@komposter
komposter deleted the feature/qr-code-upload branch April 25, 2026 17:44
@H1D

H1D commented Apr 25, 2026

Copy link
Copy Markdown
Owner

#10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants