Skip to content

Handler #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 9, 2024
Merged

Handler #231

merged 15 commits into from
Nov 9, 2024

Conversation

H1rono
Copy link
Owner

@H1rono H1rono commented Nov 7, 2024

close #43

@H1rono
Copy link
Owner Author

H1rono commented Nov 7, 2024

  • ドキュメント書く
  • テスト書く
  • with_state

@H1rono
Copy link
Owner Author

H1rono commented Nov 7, 2024

  • example更新

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.

Project coverage is 69.80%. Comparing base (aaea27c) to head (62420b7).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/handler.rs 0.00% 77 Missing ⚠️
src/error.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   73.22%   69.80%   -3.43%     
==========================================
  Files          14       15       +1     
  Lines        1621     1702      +81     
==========================================
+ Hits         1187     1188       +1     
- Misses        434      514      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@H1rono
Copy link
Owner Author

H1rono commented Nov 7, 2024

これstructよりtraitの方が強いな...
warp::Filter並の柔軟性が欲しいが難しすぎる

@H1rono
Copy link
Owner Author

H1rono commented Nov 8, 2024

なんか違う気がするのでclose...

@H1rono H1rono closed this Nov 8, 2024
@H1rono
Copy link
Owner Author

H1rono commented Nov 8, 2024

待ってできてるかも!!!!

@H1rono H1rono reopened this Nov 8, 2024
@H1rono
Copy link
Owner Author

H1rono commented Nov 9, 2024

一旦マージするか...

@H1rono H1rono merged commit 47c8ccd into main Nov 9, 2024
5 of 7 checks passed
@H1rono H1rono deleted the handler branch November 9, 2024 10:05
@H1rono H1rono mentioned this pull request Nov 9, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handler
1 participant