RHELMISC-4745: Add ability to bring up previous session #487

Jedoku · 2024-10-07T01:21:19Z

WIP

bin/auto_hck

lib/project.rb

lib/setupmanagers/qemuhck/qemu_machine.rb

akihikodaki · 2024-10-10T12:38:06Z

I'm not a fan of this idea. It brings significant complexity similar to --dump, which adds an alternative way to run tests.
Its use case is also unclear; I often repeatedly run tests using the command line history and I'm satisfied with it.

lib/session.rb

lib/setupmanagers/qemuhck/qemu_machine.rb

lib/engines/hcktest/playlist.rb

lib/engines/hcktest/tools.rb

lib/project.rb

lib/session.rb

lib/models/session.rb

lib/session.rb

lib/cli.rb

lib/session.rb

lib/models/session.rb

lib/engines/hcktest/hcktest.rb

lib/project.rb

lib/session.rb

lib/models/session.rb

lib/project.rb

lib/setupmanagers/qemuhck/qemu_machine.rb

lib/engines/hcktest/hcktest.rb

lib/session.rb

lib/cli.rb

akihikodaki

The current implementation will leave an immature session if an error happens before clients get configured. Save the session after it is fully initialized (i.e., all clients are configured).

lib/cli.rb

Jedoku · 2025-01-31T10:01:15Z

The current implementation will leave an immature session if an error happens before clients get configured. Save the session after it is fully initialized (i.e., all clients are configured).

But this is one of features, you can bring up VM`s for checking what's goin on and where it's crash

lib/cli.rb

lib/engines/hcktest/hcktest.rb

lib/project.rb

Copilot

Pull Request Overview

This PR adds the ability to bring up a previous session by introducing session management and adjusting workspace and client configuration flows accordingly. Key changes include:

Introducing a new Session model (lib/session.rb) with save/load functionality.
Updating project initialization and workspace restoration logic (lib/project.rb and related files).
Extending CLI options to support session-related arguments and refining client and test configurations based on session status.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/setupmanagers/qemuhck/qemu_machine.rb	Added "configured" flag to the machine options hash and adjusted instance variable usage.
lib/setupmanagers/hckstudio.rb	Early return added when project is restored to prevent redundant pool creation.
lib/setupmanagers/hckclient.rb	Modified client configuration logic to account for a restored session condition.
lib/session.rb	New Session model added, providing save and load methods for session management.
lib/project.rb	Updated initialization to accept a session, introduced workspace restore and save.
lib/engines/hcktest/tools.rb	Modified conditional expression for results handling (potential issue identified).
lib/engines/hcktest/tests.rb	Removed an extraneous blank line.
lib/engines/hcktest/hcktest.rb	Adjusted restored session handling, updated snapshot options, and refined test logic.
lib/cli.rb	Refactored CLI options using T::Struct and added session parameters.
lib/all.rb	Added autoload for the new Session module.

lib/engines/hcktest/tools.rb

lib/setupmanagers/qemuhck/qemu_machine.rb

lib/engines/hcktest/tests.rb

lib/setupmanagers/qemuhck/qemu_machine.rb

lib/project.rb

akihikodaki

Please look at unresolved comments:

lib/engines/hcktest/hcktest.rb

lib/session.rb

akihikodaki · 2025-05-29T04:14:25Z

lib/project.rb

+    def restore_workspace
+      @workspace_path = @options.test.session
+
+      raise AutoHCKError, 'Workspace path does not exist could not load session' unless File.directory?(@workspace_path)


Rescue an error that will happen in @setup_manager_type&.enter @workspace_path when the directory is missing instead.

I decided to rise error in session class cause we already have one for regular session in Project#create_workspace

Rescue an error only when restored. Checking File.directory?(session_path) results in a duplicate file operation and a "time-of-check to time-of-use" race condition, which is why I suggest rescuing one.

It actually will be rised by OpenJsonError if it's does't exist, I dont want to rescue it's doesn't make sense for me we can have a little double operation or you can sugget another one

Why do you think it doesn't make sense? It tells the session doesn't exist, so we can tell the fact to the user.

Look, we cant catch Errno::ENOENT error here Cause its already catched by Json helper and our rescue will be ignored
So we can remove this rising of error and will see that session.JSON does not exist ant it will be unclear that workspace_path doesn't exist

akihikodaki · 2025-05-29T04:14:39Z

lib/engines/hcktest/hcktest.rb

@@ -249,12 +250,24 @@ def prepare_tests
        @project.logger.info('HLK test target is not defined, allow in manual mode')
      end

+      @tests.verify_target if @project.restored?


What is it for?

I actually don't clearly remember it but, i think it was some error relatet to target creation back then
Anyway it's works without it now

The new version removed the condition, but @tests.verify_target is still there.

Signed-off-by: Vitalii Chulak <[email protected]>

akihikodaki

Two of the last comments are not addressed.

Jedoku · 2025-05-29T05:21:27Z

Two of the last comments are not addressed.

akihikodaki

I replied to the comments so please check them out.

github-advanced-security bot found potential problems Oct 7, 2024

View reviewed changes

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch 2 times, most recently from a94ca1f to 71d5c6c Compare October 8, 2024 22:29

Jedoku requested review from akihikodaki and kostyanf14 October 8, 2024 22:52

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 71d5c6c to 7e1ff8a Compare October 18, 2024 15:48

akihikodaki requested changes Oct 19, 2024

View reviewed changes

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 7e1ff8a to 8a79a7e Compare November 27, 2024 13:14

Jedoku requested a review from akihikodaki December 1, 2024 00:10

Jedoku changed the title ~~RFC: Bring up previous session~~ Bring up previous session Dec 2, 2024

akihikodaki requested changes Dec 3, 2024

View reviewed changes

lib/project.rb Outdated Show resolved Hide resolved

lib/session.rb Outdated Show resolved Hide resolved

lib/models/session.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 8a79a7e to 0ba68bc Compare December 19, 2024 08:54

Jedoku requested a review from akihikodaki December 19, 2024 09:06

akihikodaki requested changes Dec 19, 2024

View reviewed changes

lib/session.rb Outdated Show resolved Hide resolved

lib/session.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch 2 times, most recently from 72f53ca to dd5ec70 Compare January 22, 2025 09:01

Jedoku requested a review from akihikodaki January 22, 2025 11:17

akihikodaki requested changes Jan 23, 2025

View reviewed changes

kostyanf14 reviewed Jan 23, 2025

View reviewed changes

lib/setupmanagers/qemuhck/qemu_machine.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch 2 times, most recently from a63b74b to 0f480a0 Compare January 30, 2025 03:51

Jedoku requested review from kostyanf14 and akihikodaki January 30, 2025 03:53

akihikodaki requested changes Jan 30, 2025

View reviewed changes

lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved

lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved

lib/session.rb Outdated Show resolved Hide resolved

lib/session.rb Outdated Show resolved Hide resolved

lib/cli.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 0f480a0 to df1cc61 Compare January 31, 2025 00:09

akihikodaki requested changes Jan 31, 2025

View reviewed changes

lib/cli.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from df1cc61 to 1684f10 Compare January 31, 2025 10:02

kostyanf14 reviewed Jan 31, 2025

View reviewed changes

lib/cli.rb Outdated Show resolved Hide resolved

akihikodaki reviewed Apr 10, 2025

View reviewed changes

lib/cli.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from db2afd6 to 155f725 Compare April 28, 2025 08:44

github-advanced-security bot found potential problems Apr 28, 2025

View reviewed changes

lib/engines/hcktest/hcktest.rb Fixed Show fixed Hide fixed

lib/project.rb Fixed Show fixed Hide fixed

lib/project.rb Fixed Show fixed Hide fixed

lib/project.rb Fixed Show fixed Hide fixed

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 155f725 to b6b7346 Compare April 28, 2025 11:09

Jedoku requested review from akihikodaki and Copilot April 28, 2025 16:57

Copilot AI reviewed Apr 28, 2025

View reviewed changes

lib/engines/hcktest/tools.rb Outdated Show resolved Hide resolved

akihikodaki requested changes Apr 29, 2025

View reviewed changes

lib/setupmanagers/qemuhck/qemu_machine.rb Outdated Show resolved Hide resolved

lib/engines/hcktest/tests.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from b6b7346 to 76061d7 Compare April 29, 2025 11:22

Jedoku requested a review from akihikodaki April 29, 2025 11:25

akihikodaki requested changes May 4, 2025

View reviewed changes

lib/setupmanagers/qemuhck/qemu_machine.rb Outdated Show resolved Hide resolved

lib/project.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 76061d7 to ca47498 Compare May 25, 2025 17:48

Jedoku requested a review from akihikodaki May 25, 2025 18:58

akihikodaki requested changes May 26, 2025

View reviewed changes

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch 2 times, most recently from 808104f to 7158cf5 Compare May 26, 2025 20:54

Jedoku requested a review from akihikodaki May 26, 2025 21:04

akihikodaki requested changes May 28, 2025

View reviewed changes

lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved

lib/engines/hcktest/hcktest.rb Outdated Show resolved Hide resolved

lib/session.rb Outdated Show resolved Hide resolved

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from 7158cf5 to af17bd2 Compare May 29, 2025 01:37

Jedoku requested a review from akihikodaki May 29, 2025 01:38

akihikodaki requested changes May 29, 2025

View reviewed changes

RHELMISC-4745: Add ability to bring up previous session

dd1caeb

Signed-off-by: Vitalii Chulak <[email protected]>

Jedoku force-pushed the Add-ability-to-bring-up-previous-session branch from af17bd2 to dd1caeb Compare May 29, 2025 05:03

Jedoku requested a review from akihikodaki May 29, 2025 05:04

akihikodaki requested changes May 29, 2025

View reviewed changes

Jedoku closed this May 29, 2025

Jedoku reopened this May 29, 2025

Jedoku requested a review from akihikodaki May 29, 2025 05:27

akihikodaki requested changes May 29, 2025

View reviewed changes

RHELMISC-4745: Add ability to bring up previous session #487

Are you sure you want to change the base?

RHELMISC-4745: Add ability to bring up previous session #487

Conversation

Jedoku commented Oct 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akihikodaki commented Oct 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akihikodaki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jedoku commented Jan 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akihikodaki left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jedoku commented Oct 7, 2024 •

edited

Loading