Skip to content

Issue54: fix compiler warnings by adding explicit type casts #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Leyrer-PNP
Copy link

secdom.c:455:17: warning: conversion from 'long unsigned int' to 'WORD' {aka 'short unsigned int'} may change value [-Wconversion]
  455 |     ValueLength -= sizeof(WORD);
      |     ~~~~~~~~~~~~^~~~~~~~~~~~~~~
secdom.c:491:35: warning: conversion from 'size_t' {aka 'long unsigned int'} to 'int' may change value [-Wconversion]
  491 |         *pInfoLen = strlen(*pInfo)+1;
      |                     ~~~~~~~~~~~~~~^~

Fixed by adding explicit type casts. (and I also removed the DOS EOL characters).

#include "osmem.h"
#include "lookup.h"
#include "dsapi.h"
#include "addin.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes not seeing any needed changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the comments from the includes was not part of this pull request. Not my change, at least in this pull request.

@saravananbalakris
Copy link
Contributor

Closing this as its been merged with other PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants