Merge test file generators for tools #5515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
the
Priority - 2. Medium
mattjala
requested review from
derobins,
byrnHDF,
fortnern and
jhendersonHDF
as code owners
mattjala
added
the
Component - Testing
mattjala
requested review from
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
brtnfld
as code owners
mattjala
commented
May 6, 2025
mattjala
commented
May 6, 2025
tools/test/misc/h5clear_gentest.c
Outdated
| return 1; | ||
| } /* gen_enhance_files() */ | ||
|
|
||
| #define FILENAME_ENHANCE_6 \ |
There was a problem hiding this comment.
These entries were removed from the FILENAME_ENHANCE array since they're used in a different manner, and because doing so allowed the core/script split to be done more cleanly. Entries 6 and 7 were only used in main, while 0-5 were only used in the routines.
h5clear_gentest was excluded from h5gentest because it exits in a specific way to leave IDs open. |
|
Just a couple minor comments but this looks pretty good to me. |
jhendersonHDF
approved these changes
May 19, 2025
fortnern
approved these changes
May 27, 2025
|
The commit title/description for this PR could likely use a bit of editing before merge as the purpose has changed a bit from the original idea. |
mattjala
changed the title
github-project-automation
bot
moved this from In progress
to Done
in HDF5 - TRIAGE & TRACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow gentest scripts to share routines between each other, so that cases where multiple tools tests require the same file can be handled without directly copying the files or duplicating file generation routines.
Split the tool gentest files into source and header portions.
Actual test file generation is now done through a single script with command line options