-
-
Notifications
You must be signed in to change notification settings - Fork 290
Split tool test generators into core/header files #5515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
tools/test/misc/h5clear_gentest.c
Outdated
return 1; | ||
} /* gen_enhance_files() */ | ||
|
||
#define FILENAME_ENHANCE_6 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These entries were removed from the FILENAME_ENHANCE array since they're used in a different manner, and because doing so allowed the core/script split to be done more cleanly. Entries 6 and 7 were only used in main
, while 0-5 were only used in the routines.
h5clear_gentest was excluded from h5gentest because it exits in a specific way to leave IDs open. |
Just a couple minor comments but this looks pretty good to me. |
This will allow gentest scripts to share routines between each other, so that cases where multiple tools tests require the same file can be handled without directly copying the files or duplicating file generation routines.
The core file for each tool contains the definitions for the routines that generate test files.
The executable file is built into the gentest script, which uses the routines defined in each core file.
The header declares the routines and any values that need to be shared between the executable and the core file.