Skip to content

Bring h5diffgentest in line with expected test files #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mattjala
Copy link
Contributor

@mattjala mattjala commented Apr 18, 2025

  • Add files to gentest script: trefer_attr.h5, tvlstr.h5, tvlstr2.h5

The routines to build these are copied from h5dumpgentest. It might make sense to eventually have a separate collection of shared build file generator routines that can be shared between gentest scripts.

  • Fix cases where the expected datataype does not match the generated one

  • Fix some object names not matching their expected values

  • Update test files and expected files for test_comps_array_vlen and test_comps_vlen_arry

  • Fixed incorrect datasets being compared for compound dataset test

  • Update the (disabled for now) h5diffgentest CMake test to create files in the correct directories

We can't just copy the testfiles to the parallel directory because the active VOL connector may not use files.

@mattjala mattjala added Priority - 2. Medium It would be nice to have this in the next release Component - Testing Code in test or testpar directories, GitHub workflows Type - Bug / Bugfix labels Apr 18, 2025
@mattjala mattjala self-assigned this Apr 18, 2025
@byrnHDF
Copy link
Contributor

byrnHDF commented Apr 18, 2025

One thing that is missing and needs to be handled - the tools will need reference files generated if any of the testfiles change.

@mattjala
Copy link
Contributor Author

One thing that is missing and needs to be handled - the tools will need reference files generated if any of the testfiles change.

None of the testfiles are changed here. The gentest script is out of date and currently creates testfiles that are different than the one we have committed. This is changing gentest to create testfiles identical to the ones we already have.

byrnHDF
byrnHDF previously approved these changes Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Testing Code in test or testpar directories, GitHub workflows Priority - 2. Medium It would be nice to have this in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants