Corrected colon behavior and UD with zero elements #5480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 0. Blocker ⛔
Component - Tools
byrnHDF
requested review from
bmribler,
brtnfld,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
Contributor
|
This should include a test to prevent regression. It looks like a duplicate of one of the existing tests in |
Contributor
Author
Maybe for the zero case with added params. but it would need to fail if extra params are added. |
bmribler
previously approved these changes
May 1, 2025
lrknox
approved these changes
May 13, 2025
Collaborator
@mattjala, Allen added a test after your comment. Does it sufficiently address this? |
mattjala
approved these changes
May 23, 2025
github-project-automation
bot
moved this from Scheduled/On-Deck
to Done
in HDF5 - TRIAGE & TRACK
qkoziol
pushed a commit
to qkoziol/hdf5
that referenced
this pull request
Oct 11, 2025
* Add test for nelems different then required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues stated in #5132, but the comment about a segfault might have been addressed in the code changes.