-
-
Notifications
You must be signed in to change notification settings - Fork 294
Add H5Dread_chunk2() #5506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fortnern
wants to merge
15
commits into
HDFGroup:develop
Choose a base branch
from
fortnern:secure_read_chunk
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add H5Dread_chunk2() #5506
+1,030
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtnfld
reviewed
May 7, 2025
brtnfld
reviewed
May 12, 2025
brtnfld
reviewed
May 12, 2025
@fortnern , I finished with the Fortran additions, you might want to bring the PR in sync with develop |
@fortnern, I don't think those failing test are related to my changes. All tests pass on my OpenSUSE |
Fix test failures Add useful error messages to direct_chunk.c Other test updates/fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Build
CMake, Autotools
Component - C Library
Core C library issues (usually in the src directory)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version H5Dread_chunk() according to the standard HDF5 API versioning scheme. H5Dread_chunk2() takes an additional parameter that points to a variable containing the size of the buffer on entry, and is set to the needed size on exit. Deprecated H5Dread_chunk1(). The FORTRAN interface still needs to be updated.
Resolves #5224