Skip to content

Using system compress libs add dependency to the install #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 13, 2025

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented May 22, 2025

Fixes #5516, and fixes #5525 but needs verification.

@nbagha1 nbagha1 moved this from To be triaged to In progress in HDF5 - TRIAGE & TRACK May 23, 2025
@nbagha1 nbagha1 added this to the Release 2.0.0 milestone May 23, 2025
@@ -105,6 +105,19 @@ if (${HDF5_PACKAGE_NAME}_BUILD_JAVA)
)
endif ()

if (${HDF5_PACKAGE_NAME}_ENABLE_ZLIB_SUPPORT AND NOT @ZLIB_USE_EXTERNAL@)
if (@HDF5_MODULE_MODE_ZLIB@)
# Expect that the default shared library is expected with FindZLIB.cmake
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably Expect and expected don't both belong in this sentence?

@lrknox lrknox merged commit f2d2d45 into HDFGroup:develop Jun 13, 2025
70 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in HDF5 - TRIAGE & TRACK Jun 13, 2025
@byrnHDF byrnHDF deleted the develop-sys-depends branch June 13, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools
Projects
Status: Done
4 participants