Add h5ls test files to gentest #5559
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
the
Priority - 2. Medium
mattjala
added
the
Component - Tools
mattjala
requested review from
jhendersonHDF,
qkoziol,
vchoi-hdfgroup and
bmribler
as code owners
mattjala
added
the
Component - Testing
hyoklee
approved these changes
May 30, 2025
bmribler
reviewed
Jun 10, 2025
| } | ||
|
|
||
| /* Create a new file using default properties */ | ||
| file_id = H5Fcreate(TDSET_FILENAME, H5F_ACC_TRUNC, H5P_DEFAULT, H5P_DEFAULT); |
There was a problem hiding this comment.
Do we have a standard on error checking for test file generators? I looked at the existing ones, it's a mix. It's not in https://github.com/HDFGroup/hdf5/wiki/Getting-Started-with-HDF5-Development, BTW.
There was a problem hiding this comment.
No. Some test generators return an error code, some print an error message and try to continue, some use asserts, and some directly exit on failure. I've been keeping the error handling as-is and just taking advantage of it where it exists to track nerrors in h5gentest. It would be nice to make this consistent across generators, but that should probably be considered separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h5ls currently has no script to generate the test files it uses on the fly. This adds support for h5ls test file generation to the gentest script.