Move h5repacktst file generation to h5repackgentest #5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
the
Priority - 2. Medium
mattjala
added
the
Component - Tools
mattjala
requested review from
fortnern,
jhendersonHDF,
qkoziol and
vchoi-hdfgroup
as code owners
mattjala
added
the
Component - Testing
mattjala
commented
Jun 3, 2025
| */ | ||
| int | ||
| make_h5repack_testfiles(void) |
There was a problem hiding this comment.
These ~5,000 lines are just copied from h5repacktst.c and don't need to be closely inspected
mattjala
commented
Jun 3, 2025
|
|
||
| #define MAX_NAME_SIZE 256 | ||
| #define PAGE_SIZE_DEFAULT 4096 |
There was a problem hiding this comment.
h5repacktst originally used FS_PAGESIZE_DEF from h5repack.h. To avoid using h5repack internal symbols, we define a different symbol here with the same value.
mattjala
commented
Jun 3, 2025
| int verify_userblock(const char *filename); | ||
|
|
||
| /* fill value test */ | ||
| #define H5REPACK_FNAME0 "h5repack_fill.h5" |
There was a problem hiding this comment.
These symbols are shared between h5repackgentest.c and h5repacktst.c
|
Marked as draft until I fix build issues on Windows |
mattjala
force-pushed
the
h5repacktst_no_gen
branch
from
da59399 to
22f9b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated primarily by the need to be able to generate the h5repacktst files for h5repack VOL tests.
This currently only applies to VFD tests for h5repack.