Correct name of CMake option to HDF5_ENABLE_DEPRECATED_SYMBOLS #5587
Conversation
byrnHDF
requested review from
lrknox,
derobins,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler and
glennsong09
as code owners
byrnHDF
added
the
Priority - 0. Blocker
byrnHDF
added
the
Component - Testing
There was a problem hiding this comment.
The only gcc DBG v2.0.0 default API workflow in main-cmake-spc.yml that fails due to use of a deprecated function is the v2.0.0 default API. The others fail because src/H5version.h : 54 doesn't allow both H5_USE_*_API and H5_NO_DEPRECATED_SYMBOLS. v2.0.0 will also fail as soon as there is a newer version. We'll need to add the HDF5_ENABLE_DEPRECATED_SYMBOLS option to a workflow that doesn't also specify an older version.
github-project-automation
bot
moved this from To be triaged
to In progress
in HDF5 - TRIAGE & TRACK
|
We should implement a YML function that checks when an unknown CMake option is used in our CI testing, to prevent this issue from happening in the future. |
… into develop-depr-wflw
| @@ -333,7 +328,7 @@ jobs: | |||
| -DZLIB_USE_LOCALCONTENT=OFF \ | |||
| -DHDF5_ENABLE_MIRROR_VFD:BOOL=ON \ | |||
| -DHDF5_ENABLE_DIRECT_VFD:BOOL=ON \ | |||
| -DH5_NO_DEPRECATED_SYMBOLS:BOOL=OFF \ | |||
| -DHDF5_ENABLE_DEPRECATED_SYMBOLS:BOOL=OFF \ | |||
There was a problem hiding this comment.
Leaving this as an exercise when version 3.0 and -DHDF5_DEFAULT_API_VERSION:STRING=v2 come along?
There was a problem hiding this comment.
When that happens then there will be a new latest version and previous one will need to remove the option.
Fixes #5591