Fix a crash when duplicate addesses occur (related to CVE-2025-6269) #5924
+89
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When two entries in the cache image have the same address, the library did not fail and later crashed. The cache reconstruction functions now detect duplicate addresses. When a failure occurs during the reconstruction, the cache is not clean properly. H5C__reconstruct_cache_contents now expunges any prefetched entries that were already added to the cache during the reconstruction.
bmribler
requested review from
byrnHDF,
derobins,
fortnern,
jhendersonHDF and
lrknox
as code owners
bmribler
requested review from
brtnfld,
glennsong09,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
bmribler
changed the title
bmribler
commented
Oct 17, 2025
|
|
||
| /* Only touch entries from the image reconstruction */ | ||
| if (entry_ptr->type->id == H5AC_PREFETCHED_ENTRY_ID) { | ||
| /* if (!entry_ptr->is_pinned && !entry_ptr->is_protected) |
There was a problem hiding this comment.
@fortnern I'm not sure if I need to check for pin and protect here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two entries in the cache image have the same address, the library did not fail and later crashed. This occurred in the debug build of the issue #5579, CVE-2025-6269.
The cache reconstruction functions now detect duplicate addresses. When a failure occurs during the reconstruction, the cache is not clean properly. H5C__reconstruct_cache_contents now expunges any prefetched entries that were already added to the cache during the reconstruction.
Important
Fix crash by detecting and handling duplicate addresses during cache reconstruction in
H5C__reconstruct_cache_contents.H5C__reconstruct_cache_contentsinH5Cimage.cnow detects duplicate addresses using a hash table and fails gracefully if duplicates are found.H5C_recon_entry_tstructure to track addresses and entries during reconstruction.H5C__reconstruct_cache_contentsto clean up partially processed entries and hash table on failure.This description was created by
for 9b19286. You can customize this summary. It will automatically update as commits are pushed.