Update the version to 2.1 #6147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java Version Synchronization Self-Contained version information for CMake Files bin/h5vers no longer needed for version updates
brtnfld
requested review from
bmribler,
byrnHDF,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
qkoziol and
vchoi-hdfgroup
as code owners
hyoklee
reviewed
Jan 7, 2026
Collaborator
Author
|
Remove the use of .in files for docs. Update the README.md file, updated the timeline chart. |
Collaborator
Author
|
@loricooperhdf, please review the README.md, https://github.com/brtnfld/hdf5/tree/vers I'm not sure the JAVA section needs to be called out; it should probably be handled like the other subtopics |
This commit adds the shared files that were referenced in commit e401a86 but were accidentally not included: - config/cmake/HDF5VersionParsing.cmake: Shared version parsing module - config/cmake/templates/H5Version.java.in: Single Java version template Also adds documentation for the code quality improvements: - CODE_QUALITY_IMPROVEMENTS.md: Comprehensive documentation - DRY_IMPROVEMENTS.md: DRY-specific documentation These files are required by the changes in commit e401a86.
Added two dynamic badges that track release blocker progress: - Release Blockers badge (links to Project HDFGroup#39) - Release Must Do badge (links to Project HDFGroup#39) Badges are updated automatically by the update-progress workflow and display completion percentage with color coding.
Wrapped the example #define statements in @code blocks to prevent Doxygen from treating them as link references. Fixes errors: - error: explicit link request to 'define' could not be resolved
Moved detailed Maven configuration (XML snippets, platforms, repositories) to the dedicated documentation file HDF5Examples/JAVA/README-MAVEN.md. The main README now has a concise section with a link to the detailed guide, following the principle of keeping the main README focused and scannable.
Changed from Zenodo's badge format to shields.io static badge format to ensure reliable rendering. The DOI link still points to the correct Zenodo record.
Contributor
This readme is nice and clean. I like it and find no issues. I don't know any way to reduce the significance of the JAVEA text, I think it's fine. |
Collaborator
Author
|
I moved the Java blurb to another file and just referenced that. |
Moved H5Version.java.in from config/cmake/templates/ to java/templates/ for better organization. Java code should live in the java/ directory tree, not in config/cmake/. Changes: - Created java/templates/ directory - Moved H5Version.java.in to java/templates/ - Updated both CMakeLists.txt files to reference new location - Removed empty config/cmake/templates/ directory This maintains the single source of truth for the Java version template while placing it in a more logical location.
Replaced emoji characters (📖 🚀 ⚡) with standard markdown bullet points for a more professional appearance in the Quick Start section.
Member
|
@brtnfld , please update versions in https://github.com/brtnfld/hdf5/blob/vers/HDF5Examples/JAVA/README-MAVEN.md |
hyoklee
reviewed
Jan 10, 2026
Member
hyoklee
left a comment
hyoklee
left a comment
There was a problem hiding this comment.
HDF5Examples/JAVA/README-MAVEN.md needs update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, derived all the version information for H5public.h
Important
Update version to 2.1 and derive version information from
H5public.h, removingh5versscript and updating CMake and Java configurations.H5public.h.H5public.husing macros.H5public.hinHDF5config.cmakeandHDF5AsSubdirMacros.cmake.README.mdandCHANGELOG.mdusingCMakeLists.txt.H5Version.javafromH5public.hfor version consistency.H5.javato useH5Versionfor version constants.bin/h5versscript, previously used for version management.This description was created by
for 0127f3a. You can customize this summary. It will automatically update as commits are pushed.