-
-
Notifications
You must be signed in to change notification settings - Fork 350
CI: use pull_request_target so review-checklist runs on fork PRs #6435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brtnfld
merged 17 commits into
HDFGroup:develop
from
brtnfld:fix/review-checklist-fork-prs
Jun 9, 2026
Merged
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0db76a4
CI: use pull_request_target so review-checklist runs on fork PRs
brtnfld e83156d
CI: replace pull_request_target with safe two-workflow pattern for fo…
brtnfld 70a1a1b
review-checklist: fix prAuthor crash and stale comment for workflow_r…
brtnfld 32c43d0
CI: revert to pull_request_target, drop two-workflow pattern
brtnfld 4f0d6ba
CI: add zizmor workflow for GitHub Actions security analysis
brtnfld f841e32
CI: run zizmor via pip instead of third-party action
brtnfld 8add688
CI: fix codeql-action pin to commit SHA (was tag object SHA)
brtnfld 29d99d6
CI: add persist-credentials: false to review-checklist checkout
brtnfld 2199d6f
CI: hash-pin zizmor pip install; suppress expected pull-request-targe…
brtnfld af25267
CI: update actions to Node.js 24 ahead of June 16 deprecation
brtnfld 5a20031
CI: fix pip hash-pinning syntax — hash must be in requirements file
brtnfld 219303b
CI: zizmor step continue-on-error so SARIF upload always runs
brtnfld 4d7ddc5
review-checklist: skip pull_request_review on fork PRs (read-only token)
brtnfld 82e2541
review-checklist: route reviews through workflow_run for fork PR support
brtnfld d08bb8a
review-checklist: simplify to pull_request_target only, drop gather w…
brtnfld 492721e
review-checklist: auto-check approval boxes on review via workflow_run
brtnfld 2da8bc9
Merge branch 'develop' into fix/review-checklist-fork-prs
hyoklee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: zizmor | ||
|
|
||
| # Static security analysis for GitHub Actions workflows. | ||
| # Findings appear as inline annotations on PRs and in the Security tab. | ||
| # Runs zizmor directly via pip to avoid a third-party action dependency. | ||
|
|
||
| on: | ||
| push: | ||
| branches: [develop] | ||
| paths: ['.github/**'] | ||
| pull_request: | ||
| branches: [develop] | ||
| paths: ['.github/**'] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| zizmor: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| steps: | ||
Check warningCode scanning / zizmor action's hash pin has mismatched or missing version comment: points to commit 34e114876b0b Warning
action's hash pin has mismatched or missing version comment: points to commit 34e114876b0b
|
||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| with: | ||
| persist-credentials: false | ||
| - run: pip install zizmor==1.25.2 | ||
| - run: zizmor --format sarif . > zizmor-results.sarif | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - uses: github/codeql-action/upload-sarif@dd903d2e4f5405488e5ef1422510ee31c8b32357 # v3.36.2 | ||
| if: always() | ||
| with: | ||
| sarif_file: zizmor-results.sarif | ||
| category: zizmor | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.