Closed
Conversation
Roardom
requested changes
Oct 28, 2024
Obi-Wana
force-pushed
the
add-forum-edit
branch
2 times, most recently
from
8c0edf7 to
607de57
Compare
Roardom
reviewed
Oct 31, 2024
Roardom
reviewed
Oct 31, 2024
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
607de57 to
3723887
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
d8bcb0c to
de52951
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
2 times, most recently
from
ec711d4 to
e5f1341
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
2 times, most recently
from
f758bbe to
d104844
Compare
Roardom
requested changes
Jan 21, 2025
Collaborator
Roardom
left a comment
Roardom
left a comment
There was a problem hiding this comment.
Thank you!
Added some feedback
database/migrations/2024_10_28_164054_add_edited_by_to_posts_table.php
Outdated
Show resolved
Hide resolved
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
d104844 to
bb1235f
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
5bc9066 to
a08a650
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
4 times, most recently
from
b4e2978 to
8ac29f8
Compare
Obi-Wana
force-pushed
the
add-forum-edit
branch
2 times, most recently
from
e6e9aea to
1166c99
Compare
Roardom
requested changes
Apr 7, 2025
Collaborator
Roardom
left a comment
Roardom
left a comment
There was a problem hiding this comment.
Just a couple notes. Also, revel stylesheet is a bit broken with these changes
Contributor
Author
Updated revel theme. |
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
84d0676 to
ee9fa99
Compare
This moves the created/edited timestamp to the buttom of a post in the revel theme too.
Obi-Wana
force-pushed
the
add-forum-edit
branch
from
ee9fa99 to
0f98d13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "last edited by " to forum posts.
Suggestions for better naming instead of
updatedByare welcome.