Skip to content

(Refactor) Split tmdb recommendations into movies and tv #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Apr 7, 2025

No description provided.

Copy link

what-the-diff bot commented Apr 7, 2025

PR Summary

  • Elimination of the TmdbRecommendation model
    The TmdbRecommendation model was discarded as it's no longer useful.
  • Modification of ProcessMovieJob and ProcessTvJob
    The ProcessMovieJob and ProcessTvJob files were updated by removing references to the now-deleted TmdbRecommendation model.
  • Introduction of the sync method
    The dated recommendations upsert operations were swapped with the sync method. It utilized the newly introduced pivot tables (tmdb_recommended_movies and tmdb_recommended_tv).
  • Update of relationships in TmdbMovie and TmdbTv models
    The recommendedMovies and recommendedTv relationships in these models were updated to accommodate the new pivot table names.
  • Refinement of recommendation retrieval logic
    The logic to retrieve recommendations in both Movie and TV service clients has been refined to avoid unnecessary properties.
  • Migration progress
    A new migration file has been added. It creates isolated tables for movie and TV recommendations, populates them using prior data, and removes the outdated tmdb_recommendations table.

@Roardom Roardom force-pushed the split-recommendations branch 2 times, most recently from 9e996c0 to 6eb5bc3 Compare April 7, 2025 16:29
@Roardom Roardom force-pushed the split-recommendations branch from 97decf7 to e3cbfd7 Compare April 7, 2025 17:21
@HDVinnie HDVinnie merged commit 8aa6f97 into HDInnovations:development Apr 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants