Skip to content

(Remove) Tmdb keywords #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Roardom
Copy link
Collaborator

@Roardom Roardom commented Apr 8, 2025

This extra data isn't useful for anything except being spoiled about the movie/tv. The only usecase its had in the past was searching for anime, but we have a language filter for search now, and filtering by ja and animation seems to be more reliable than searching for the anime keyword.

Copy link

what-the-diff bot commented Apr 8, 2025

PR Summary

  • Elimination of Keyword Functionality
    Removal of code components that once supported keyword functionality, enhancing clarity and simplicity in application structure.
  • Extraction of Keyword Model
    Complete removal of the Keyword model, rendering the keyword capability deprecated in the app.
  • Database Modifications
    Introduction of a migration script to eliminate the keywords table from the database schema, aligning with the fulfilled removal of keywords.
  • API Documentation Amendments
    Removal of any keyword-related details from the API documentation, showcasing the absence of the feature.
  • Consistency Across Translation Files
    Updated translation files by deleting keyword references, ensuring uniformity following their model and API removal.
  • Cleanup of Unnecessary Imports and Code
    Removed unused imports and comments associated with keywords, leading to a cleaner, lighter codebase.
  • Deletion of Keyword Fetching
    Removing related API calls and processing functions from 'helper.js', leading to simpler, more streamlined code.
  • Removal of Keyword User Inputs
    Deletion of keyword fields from the user interface, simplifying user interaction and data input.
  • Removal of Keyword Display
    Erased any presentational aspects of keywords from application's interface, ensuring alignment with facility's removal.
  • Adaptation of Tests
    Tests were updated to reflect the feature removal, evidence of the application's behavior change.

This extra data isn't useful for anything except being spoiled about the movie/tv. The only usecase its had in the past was searching for anime, but we have a language filter for search now, and filtering by `ja` and `animation` seems to be more reliable than searching for the `anime` keyword.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant