(Refactor) Use laravel-data for typed form requests and DTOs #4794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roardom
force-pushed
the
laravel-data
branch
2 times, most recently
from
a7cbe68 to
257d317
Compare
Roardom
changed the title
Roardom
force-pushed
the
laravel-data
branch
3 times, most recently
from
c1bfaa9 to
ed839fd
Compare
The developer experience is much improved with the typed form requests, and matches behaviour common in other type-safe languages. It allows accessing properties directly off the dto that came from the form request with ide autocomplete, and it validates that the properties exist and are not null. It might also be the solution to fixing the livewire type errors where a user supplies a string to an int variable as well.
Roardom
force-pushed
the
laravel-data
branch
2 times, most recently
from
fd84b23 to
f6f106a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft right now, but I'm very impressed by this package. The developer experience is much improved with the typed form requests, and matches behaviour common in other type-safe languages. It allows accessing properties directly off the dto that came from the form request with ide autocomplete, and it validates that the properties exist and are not null. It might also be the solution to fixing the livewire type errors where a user supplies a string to an int variable as well.