Skip to content

Conversation

@flowerey
Copy link
Contributor

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Nov 15, 2025

PR Summary

  • Formatting Adjustment for 'bitcoin-address' Regex
    No changes to its pattern, better indentation was implemented for readability.
  • Indentation Correction for 'redis' Entry
    Improved readability through the reformatting and fixed indentation.
  • Added 'overrides' Section
    • One rule added to disable spell check in the 'lang/**' directory.
    • Another rule for enabling spell check specifically in 'lang/en/**' directory.

@Roardom
Copy link
Collaborator

Roardom commented Nov 17, 2025

Thanks for looking into this, but unfortunately it doesn't seem to work or else the CI would have failed when it found e.g. anonomously.

@flowerey
Copy link
Contributor Author

Maybe its a problem with CSpell itself. Let me look onto this.

@flowerey
Copy link
Contributor Author

Fixed now.

@Roardom
Copy link
Collaborator

Roardom commented Nov 18, 2025

Nice, can you look into why anonomously still isn't detected, even though others are?

@flowerey
Copy link
Contributor Author

Okay.

@flowerey
Copy link
Contributor Author

@Roardom fixed, but can you add what needs to be added to cspell if possible?

@Roardom
Copy link
Collaborator

Roardom commented Nov 24, 2025

Very nice. It's catching anonomously now.

I noticed you limited the files argument to only lang/en/** but we need it to process every file except those in ignorePaths. Also, I don't see any documentation for the --extractStrings argument anywhere in cspell's docs. Can you link where you found it and why it's relevant?

Can you also refrain from adding/removing trailing commas and other formatting changes?

Thanks

@flowerey
Copy link
Contributor Author

Understood.

@flowerey
Copy link
Contributor Author

Do you mean that you wanna scan all languages? Or only English? It was doing that already so

Comment on lines +20 to +21
files: |
.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that you wanna scan all languages? Or only English? It was doing that already so

Previously on my last review, this line specified only lang/en, which is why I mentioned it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if we only want to scan it, then Ill change it. I think it already checks every file under lang/en , also enabling it for other languages cause a very long github workflow error (a ton of words unknown)

Copy link
Collaborator

@Roardom Roardom Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason behind this PR was to find all the possible typos and fix them, since you had opened up numerous prs previously fixing them one at a time. Now that we have the long list automated, we can fix them all at once and prevent more from being added. For the ones in translation keys however, they should be added to the cspell.json ignore list temporarily, as it's a lot of work to swap out the keys of all 40+ languages. For the legitimate typos however, now they can be identified and fixed. The link I sent in #5111 (comment) describes how to add the overrides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Will only enable for lang/en, and will add what needs to be added to ignorelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants