-
Notifications
You must be signed in to change notification settings - Fork 427
(Fix) CSpell for lang/en folder #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
PR Summary
|
|
Thanks for looking into this, but unfortunately it doesn't seem to work or else the CI would have failed when it found e.g. |
|
Maybe its a problem with CSpell itself. Let me look onto this. |
|
Fixed now. |
|
Nice, can you look into why |
|
Okay. |
|
@Roardom fixed, but can you add what needs to be added to cspell if possible? |
|
Very nice. It's catching I noticed you limited the Can you also refrain from adding/removing trailing commas and other formatting changes? Thanks |
|
Understood. |
|
Do you mean that you wanna scan all languages? Or only English? It was doing that already so |
| files: | | ||
| . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that you wanna scan all languages? Or only English? It was doing that already so
Previously on my last review, this line specified only lang/en, which is why I mentioned it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well if we only want to scan it, then Ill change it. I think it already checks every file under lang/en , also enabling it for other languages cause a very long github workflow error (a ton of words unknown)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason behind this PR was to find all the possible typos and fix them, since you had opened up numerous prs previously fixing them one at a time. Now that we have the long list automated, we can fix them all at once and prevent more from being added. For the ones in translation keys however, they should be added to the cspell.json ignore list temporarily, as it's a lot of work to swap out the keys of all 40+ languages. For the legitimate typos however, now they can be identified and fixed. The link I sent in #5111 (comment) describes how to add the overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Will only enable for lang/en, and will add what needs to be added to ignorelist.
No description provided.