Skip to content

New unit tests #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hier0p wants to merge 1 commit into
base: development
Choose a base branch
from
Draft

New unit tests #5180

hier0p wants to merge 1 commit into from

Conversation

@hier0p
Copy link

@hier0p hier0p commented Dec 28, 2025

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Dec 28, 2025

PR Summary

  • Addition of Update User Password Test File

    • Ensures users can successfully change passwords with existing correct ones.
    • Triggers validation when incorrect current password is entered.
    • Discovers issue with confirmation password check due to rule omission.
    • Verifies that weak passwords are rejected for safety.

  • Inclusion of Update User Profile Information Test File

    • Checks for error when invalid field name is used for update, e.g., 'username' instead of 'name'.
    • Enforces both 'name' and 'email' fields for profile updates.
    • Confirms email is in correct format and uniqueness is preserved.

hier0p
hier0p commented Dec 28, 2025
View reviewed changes
tests/Unit/Actions/Fortify/UpdateUserPasswordTest.php
'current_password' => $oldPassword,
'password' => $newPassword,
'password_confirmation' => $differentPassword,
]);
Copy link
Author

@hier0p hier0p Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is configured to match the existing code but this looks like a bug -- should I fix the bug and update the test or do I have a gap in my understanding.

hier0p
hier0p commented Dec 28, 2025
View reviewed changes
tests/Unit/Actions/Fortify/UpdateUserProfileInformationTest.php
expect(fn() => $action->update($user, [
'name' => fake()->name,
'email' => fake()->freeEmail,
]))->toThrow(QueryException::class);
Copy link
Author

@hier0p hier0p Dec 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the command is using name but the User model has username. Is it OK to update the command or am I misunderstanding how things work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hier0p