(Add) Extended user statistics to API endpoint #5181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
Roardom
requested changes
Dec 29, 2025
Collaborator
Roardom
left a comment
Roardom
left a comment
There was a problem hiding this comment.
This is a good PR. I'm currently working on a more refined compartmentalized framework for api usage/keys and will consider this PR as soon as that framework is in place.
Comment on lines
43
to
46
| $bonusUploaded = BonTransactions::query() | ||
| ->where('sender_id', '=', $user->id) | ||
| ->where('name', 'like', '%Upload%') | ||
| ->sum('cost'); |
Collaborator
There was a problem hiding this comment.
Suggested change
| $bonusUploaded = BonTransactions::query() | |
| ->where('sender_id', '=', $user->id) | |
| ->where('name', 'like', '%Upload%') | |
| ->sum('cost'); | |
| $bonusUploaded = BonTransactions::query() | |
| ->where('sender_id', '=', $user->id) | |
| ->where('name', 'like', '%Upload%') | |
| ->sum('cost'); |
Wildcard searches shouldn't be permitted in the api.
Comment on lines
29
to
30
| $history = DB::table('history') | ||
| ->where('user_id', '=', $user->id) |
Collaborator
There was a problem hiding this comment.
Suggested change
| $history = DB::table('history') | |
| ->where('user_id', '=', $user->id) | |
| $history = History::query() | |
| ->withTrashed() | |
| ->where('user_id', '=', $user->id) |
app/Http/Resources/UserResource.php
Outdated
Comment on lines
82
to
87
| 'real_uploaded' => str_replace("\u{00A0}", ' ', StringHelper::formatBytes((int) ($this->history?->upload_sum ?? 0), 2)), | ||
| 'real_downloaded' => str_replace("\u{00A0}", ' ', StringHelper::formatBytes((int) ($this->history?->download_sum ?? 0), 2)), | ||
| 'credited_uploaded' => str_replace("\u{00A0}", ' ', StringHelper::formatBytes((int) ($this->history?->credited_upload_sum ?? 0), 2)), | ||
| 'credited_downloaded' => str_replace("\u{00A0}", ' ', StringHelper::formatBytes((int) ($this->history?->credited_download_sum ?? 0), 2)), | ||
| 'average_seedtime' => StringHelper::timeElapsed($avgSeedtime), | ||
| 'seeding_size' => str_replace("\u{00A0}", ' ', StringHelper::formatBytes($this->seedingSize, 2)), |
Collaborator
There was a problem hiding this comment.
These should be raw values, not human ones.
app/Http/Resources/UserResource.php
Outdated
| 'fl_tokens' => $this->fl_tokens, | ||
| 'uploads_count' => $this->uploadsCount, | ||
| 'downloads_count' => (int) ($this->history?->download_count ?? 0), | ||
| 'bonus_uploaded' => str_replace("\u{00A0}", ' ', StringHelper::formatBytes($this->bonusUploaded, 2)), |
app/Http/Resources/UserResource.php
Outdated
Comment on lines
67
to
69
| $avgSeedtime = $this->history?->count > 0 | ||
| ? (int) (($this->history->seedtime_sum ?? 0) / $this->history->count) | ||
| : 0; |
Collaborator
There was a problem hiding this comment.
You should be able to use resource loading instead of manual db queries and passing them through: https://laravel.com/docs/12.x/eloquent-resources#conditional-relationships
- Use History::query()->withTrashed() instead of DB facade
- Replace wildcard LIKE with whereRelation('exchange', 'upload', true)
- Return raw integers instead of formatted strings
- Remove custom constructor, use standard resource pattern
Roardom
reviewed
Jan 9, 2026
Collaborator
Roardom
left a comment
Roardom
left a comment
There was a problem hiding this comment.
My review at this point is still the same:
This is a good PR. I'm currently working on a more refined compartmentalized framework for api usage/keys and will consider this PR as soon as that framework is in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
/api/userendpoint with additional statistics already available on the profile page:real_uploaded/real_downloaded- actual transfer amountscredited_uploaded/credited_downloaded- with bonus multipliers appliedaverage_seedtime- average seed time per torrentseeding_size- total size of torrents currently seedingfl_tokens- freeleech tokensuploads_count/downloads_count- torrent countsbonus_uploaded- upload purchased with bonus pointsChanges
app/Http/Controllers/API/UserController.php- added history aggregation queryapp/Http/Resources/UserResource.php- added new fields to responsebook/src/torrent_api.md- updated API documentation