(Remove) Redundant TMDB ID value check that's always true

[Oha-you]

To reproduce:

• Open Torrent Upload form
• Set Title and some IDs: TMDB movie/TV ID, IMDB ID, MAL ID or TVDB ID
• Pick a .torrent file
• Observe that all IDs are reset

Note: this doesn't happen when you change the category first.
But it does happen if you set it on page load with torrents/create?category_id=2

I'm not sure why cat = $refs.catId.value was needed in @change originally for #2243
Because cat is assigned here anyway:

UNIT3D/resources/views/torrent/create.blade.php

Lines 44 to 48 in 735b4b7

	<section
	class="upload panelV2"
	x-data="{
	cat: {{ old('category_id', (int) $category_id) }},
	cats: JSON.parse(atob('{{ base64_encode(json_encode($categories)) }}')),

Values are reset because they listen to cat changes:

UNIT3D/resources/views/torrent/create.blade.php

Line 316 in 735b4b7

x-bind:value="cats[cat].type === 'movie' && tmdb_movie_exists ? '{{ old('tmdb_movie_id', $movieId) }}' : ''"

When you change the category from the dropdown list, IDs should reset - this is correct.
Also IDs are retrieved through TMDB API when the Title is not set and .torrent is selected.
But after you fill all the inputs in the upload form yourself, they shouldn't be touched.

[what-the-diff]

PR Summary

• Removed value assignment in event handler
  Refactored the code to improve efficiency by eliminating the assignment of a value in an event handler for a file input.

[Oha-you]

Adding another commit here.
Condition in parenthesis always returns true because one of #auto_tmdb_movie or #auto_tmdb_tv values is always NULL depending on whether Movie or TV category is selected:

UNIT3D/resources/js/unit3d/helper.js

Line 191 in 735b4b7

if (!name.value.trim() && (!tmdb_movie.value.trim() || !tmdb_tv.value.trim())) {

Introduced after the split happened: #4563
Originally this logic was added by me back in 2021: #1760

But I think just checking if the title is set should be enough. I doubt people set DB IDs first when they upload a torrent anyway.

[Roardom]

I believe the reason this code is needed is because the uploadExtension.hook() changes #autocat's value, and alpine.js's x-model down below doesn't register this change and update its value, so it has to be done manually.

[Oha-you]

You were right. But what if we trigger the change event in JS instead of the template?
Please see the updated commit.
Tested it with Movies and TV category selected by default, then added a TV/Movie torrent.
@change event was triggered and DB ID inputs got updated.
This discussion helped: alpinejs/alpine#1388

[Roardom]

I think I'd rather keep the explicitness for now. It's impossible to link the event emitters to the event listeners in the code, and at least the way it was before, it was all referenced on the same line. Maybe at some point it can be all moved into alpine. For now, can you revert the changes you made to the category changing?

[Oha-you]

Alright, first commit removed. Also changed the PR title.

[Roardom]

Thank you!