WIP (Please ignore for now) - Refactoring and optimisations when noticed#1569
Open
loki-sinclair-hdruk wants to merge 4 commits intodevfrom
Open
WIP (Please ignore for now) - Refactoring and optimisations when noticed#1569loki-sinclair-hdruk wants to merge 4 commits intodevfrom
loki-sinclair-hdruk wants to merge 4 commits intodevfrom
Conversation
… 2N problems. Makes use of existing data to avoid duplicated queries. Eliminates full table ID scan when no title filter. A couple of instances of fetching only needed columns instead of full roes. An instance of 2 queries being replaced by 1.
|
🚨 Invalid PR title format! Your PR title must follow one of these formats:
Please update your PR title accordingly. 😊 |
dnhdruk
approved these changes
Mar 5, 2026
|
🚨 Invalid PR title format! Your PR title must follow one of these formats:
Please update your PR title accordingly. 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
number of optimisations noticed while refactoring. Fixes N+1, and N+1 2N problems. Makes use of existing data to avoid duplicated queries. Eliminates full table ID scan when no title filter. A couple of instances of fetching only needed columns instead of full roes. An instance of 2 queries being replaced by 1.
Screenshots (if relevant)
Describe your changes
Issue ticket link
Environment / Configuration changes (if applicable)
Requires migrations being run?
If not using the pre-push hook. Confirm tests pass:
Checklist before requesting a review