Skip to content

WIP (Please ignore for now) - Refactoring and optimisations when noticed#1569

Open
loki-sinclair-hdruk wants to merge 4 commits intodevfrom
feat/GAT-0000-services
Open

WIP (Please ignore for now) - Refactoring and optimisations when noticed#1569
loki-sinclair-hdruk wants to merge 4 commits intodevfrom
feat/GAT-0000-services

Conversation

@loki-sinclair-hdruk
Copy link
Contributor

number of optimisations noticed while refactoring. Fixes N+1, and N+1 2N problems. Makes use of existing data to avoid duplicated queries. Eliminates full table ID scan when no title filter. A couple of instances of fetching only needed columns instead of full roes. An instance of 2 queries being replaced by 1.

Screenshots (if relevant)

Describe your changes

Issue ticket link

Environment / Configuration changes (if applicable)

Requires migrations being run?

If not using the pre-push hook. Confirm tests pass:

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added appropriate unit tests
  • I have created mocks for unit tests (where appropriate)
  • I have added appropriate Behat tests to confirm AC (if applicable)
  • I have added Swagger annotations for new endpoints (if applicable)
  • I have added audit logs for new operation logic (if applicable)
  • I have added new environment variables to the .env.example file (if applicable)
  • I have added new environment variables to terraform repository (if applicable)

… 2N problems. Makes use of existing data to avoid duplicated queries. Eliminates full table ID scan when no title filter. A couple of instances of fetching only needed columns instead of full roes. An instance of 2 queries being replaced by 1.
@gh-actions-pipelines-app
Copy link

🚨 Invalid PR title format!

Your PR title must follow one of these formats:

  • feat(GAT-1234): Your title
  • fix!(GAT-5678): Breaking change
  • RELEASE: vX.Y.Z

Please update your PR title accordingly. 😊

@gh-actions-pipelines-app
Copy link

🚨 Invalid PR title format!

Your PR title must follow one of these formats:

  • feat(GAT-1234): Your title
  • fix!(GAT-5678): Breaking change
  • RELEASE: vX.Y.Z

Please update your PR title accordingly. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants