feat(GAT-8821): Correct DAR dialog & save draft logic - #1578
Merged
Conversation
philreekshdr
had a problem deploying
to
cypress_dev
July 17, 2026 14:38 — with 
GitHub Actions
Failure
GitHub Actions
Failure
|
🎉 Great job! Your PR title follows the correct format. 🚀 |
philreekshdr
changed the title
philreekshdr
had a problem deploying
to
cypress_dev
July 20, 2026 12:47 — with
GitHub Actions
Failure
GitHub Actions
Failure
calmacx
approved these changes
Jul 20, 2026
SaharBatol-HDRUK
approved these changes
Jul 20, 2026
gh-actions-pipelines-app Bot
pushed a commit
that referenced
this pull request
Jul 24, 2026
## [2.40.0](v2.39.0...v2.40.0) (2026-07-24) ### ✨ Features * **GAT-7563:** Data Custodian Network = Split owned/associated content (#1569) ([7e462ff](7e462ff)), closes [GAT-7563](undefinedGAT-7563) * **GAT-7564:** Data custodian associated resources (#1567) ([45e9c1d](45e9c1d)), closes [GAT-7564](undefinedGAT-7564) * **GAT-7604:** Data custodian display tweaks (#1562) ([82b222c](82b222c)), closes [GAT-7604](undefinedGAT-7604) * **GAT-8094:** Display dataset aliases (#1566) ([65e819a](65e819a)), closes [GAT-8094](undefinedGAT-8094) * **GAT-8131:** Widget test harness (#1573) ([ac6fda3](ac6fda3)), closes [GAT-8131](undefinedGAT-8131) * **GAT-8478:** Add support link (#1571) ([c51fa80](c51fa80)), closes [GAT-8478](undefinedGAT-8478) * **GAT-8709:** Fix confusing naming for running a fedaration test. ([6aedd84](6aedd84)) * **GAT-8724:** Update dataset filter order (#1576) ([71843f9](71843f9)), closes [GAT-8724](undefinedGAT-8724) * **GAT-8798:** Added run now button for integrations ([f944277](f944277)), closes [GAT-8798](undefinedGAT-8798) * **GAT-8821:** Correct DAR dialog & save draft logic (#1578) ([04eace6](04eace6)), closes [GAT-8821](undefinedGAT-8821) * **GAT-9193:** Update sign-in modal design (#1581) ([ee76b95](ee76b95)), closes [GAT-9193](undefinedGAT-9193) * **GAT-9193:** Update wording (#1582) ([68ae7bb](68ae7bb)), closes [GAT-9193](undefinedGAT-9193) ### 🐛 Bug Fixes * **GAT-8754:** Fix empty widget preview state (#1577) ([a827c08](a827c08)) * **GAT-9237:** bug in the onboarding form for tools (#1579) ([2071ecb](2071ecb)), closes [GAT-9237](undefinedGAT-9237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots / videos (if relevant)
Describe your changes
DAR submission previously fired the answers-save and the status-change as two concurrent requests, which raced on the server and intermittently failed to show a confirmation — occasionally dropping the applicant's final edits while still marking the application submitted. Submission is now a single request that saves answers and flips the status to SUBMITTED in one call, with a success toast + redirect on success, and clear error toasts on failure or when required fields are missing.
The custodian "Change application status" dialog now surfaces success/error toasts and reliably navigates back to the applications list — the cache revalidation is awaited so its router refresh no longer clobbers the redirect (previously the first "set to Draft" often stayed on the page).
Finally, the "Save draft" button is now hidden when an application is no longer editable (submitted/in review, or already decided) rather than offering an action the API rejects.
Also - a sometimes failing Cohort test was improved.
Issue ticket link
https://hdruk.atlassian.net/browse/GAT-8821
Checklist before requesting a review