Open
Conversation
Older Pillow releases don't support PEP 517 builds
This requires Python 3.8 as minimal release
dimaqq
approved these changes
Apr 4, 2024
| import re | ||
| import sys | ||
| from distutils.version import StrictVersion | ||
| from packaging import version |
Contributor
There was a problem hiding this comment.
Nit: arguably version safety check could be done without the extra dep
dimaqq
reviewed
Apr 5, 2024
| if version < StrictVersion("0.16.1"): | ||
| binary_version_str = match.group(1) | ||
| binary_version = version.parse(binary_version_str) | ||
| if binary_version < version.parse("0.16.1"): |
Contributor
There was a problem hiding this comment.
That version was release on Apr 26, 2017.
Perhaps this check can be removed entirely?
Contributor
There was a problem hiding this comment.
tbh i'm fine with just removing the version check completely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests are locally still passing but please double-check the dependency updates.
Should fix #164