Support for multibeam fftvis#387
Open
steven-murray wants to merge 10 commits into
Open
Conversation
steven-murray
added
priority: high
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 93.63% 93.32% -0.32%
==========================================
Files 25 25
Lines 3348 3372 +24
Branches 557 562 +5
==========================================
+ Hits 3135 3147 +12
- Misses 112 118 +6
- Partials 101 107 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Updated the ModelData class to accept BeamInterface objects alongside existing beam types. - Modified the visibility simulator wrappers (MatVis, FFTVis) to utilize BeamInterface for beam handling. - Enhanced documentation in the end-to-end example and visibility simulator tutorial to clarify beam model handling. - Added tests to ensure ModelData correctly wraps analytic beams and defaults to BeamInterface.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #386
Adds support for multi-beam FFTVis, following tyler-a-cox/fftvis#63