[Prod] Software updates, training report redesign work, delete erroneous monitoring goals #3226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3216) * update deps * set nodemailer resolution * handle empty list of issues
…session (#3204) * Use correct form/html name in the files section on the session * Add defensive check to account for slow scan queue
…ons matrix (#3210) * Update filterEventsByStatus according to revised permissions matrix * Update other test
* Update session to save goal templates out of JSONB * Add FE filter * Update session card * Fix assorted bugs with saving/updating standard in session * Add goal category filter * remove the monitoring template * Fix rendering error in supporting goals review page * QOL and cleanup suggestions from code review
* Update session to save goal templates out of JSONB * Add FE filter * Update session card * Fix assorted bugs with saving/updating standard in session * Add goal category filter * remove the monitoring template * Fix rendering error in supporting goals review page * QOL and cleanup suggestions from code review * Leverage table added during migration for objective trainers * Fix form complete, keys
… names instead of national centers (#3202) * Update creator and collaborator filters * Implement staff provider to show names vs ids * Fix copy/paste bug and add a POC user * Update backend unit tests
* move claude example to agents.md and add PR instructions * update * add suggestions, modify personal instruction handling * update agent instructions * tweaking * move PR review instructions to copilot-specific file
* Update fengari * Fix on-headers vuln via yarn resolution
thewatermethod
changed the title
…as "Needs Action" (#3221) * Allow approvers navigate AR and CR when the first approval was needs action * update approver edit rules for needs-action reports
* Next Steps Section * Removing no-longer-needed get values button * Correctly saving CollabReportSteps * Adding empty step and implementing Next Steps isPageComplete * Improvements to CR Activity Summary ReviewSection * Improvements to CR Supporting Info ReviewSection * Improvements to CR Supp Info isPageComplete * Fix to CR Service to better handle CR Goals * Improvement to adding empty steps * Fixes to Supp Info participants and Next Steps tests * Adding better date validation to NS page. * Updating data model * Fixing it so that the correct region is being saved for CR forms * Adding missing "activity method" to the SubmittedCollabReport component * Removing un-needed console logs * Fixing it so a blank conductMethod doesn't fire a 500 * Adding collab report to print stylesheet, updating a few missing placeholders * Updating isPageComplete and related tests to better reflect singular conductMethod * Updates to better support when no collabReportSpecialists in tests * Fixing showing the "collected data - other" text input * Fixing it so that there's only one edit button in the Next Steps review section * Better handling selectedDataUsed when undefined * Adding console log to try and narrow down loading error * Updating a few tests to account for better network connection error handling. * Eslint ignoring console.warn for testing purposes * Cleaning up some faulty logic and remaining unneeded conductMethod references * Fixing display of states involved on the act sum review panel * Fixing conductMethod undefined test * Removing the "disabled" state from the CR Review and Submit "submit" button * Fixing the appearance of the "Select dropdown indicator" * Fix for "needs action" review state * Adding a non-breaking-space to Report ID table header to keep it from wrapping to next line sometimes. * Fixing it so that the CR form can be filled out in a "non-linear" way * Updating a couple Activity Summary review value logic checks * Clearing "saved draft" message on page navigation * Allow approver edits after approval and re-entry * Changing none provided to none for supp info review page * Update failing tests * Add frontend tests * Changing "pending" approval status icon to a clock icon * Updating submit button to "Update report" when updating an existing report that needs action * Removing gray hover state from review and submit accordion edit links * Fixing it so "successfully reviewed" messages don't persist on page refresh. * Adding a "submitted" alert when submitting a report * Making CR form fields responsive * Updating collabReports.ts service to account for "Needs Action" reports better * Improving a util function to better account for multi-approver reports * Updating supp info tests * Improvements to some tests * Updating yarn audit BE * Ignoring some hard-to-test functions * Remove stray files * Fixing a bug with adding approvers * Improve test coverage * Changing approval status to sentence case * Fixing it so that Goals and Data show "None" in submitted view when appropriate * Moving SCSS rules to CRForm index.scss * Adding mobile styles for status label and auto-save alert * Fixing CR Conduct Method dropdown arrow duplication * Sentence casing values and labels in Approver Screen * Adding missing "review the information before you submit" language * Fixing supp info completion status and adding inline error messages * Adding a draft alert component to the review and submit page (along with a ridiculous prop-drilling line in order to accomplish it) * Fix for "Is State or Regional" null not marking act sum page as incomplete * Setting max width for "review before submitting" text * Adding an onblur error message to the activity description textarea * Fixing activity description error text and review and submit page text style * Fixing so no selection of data used or goals yields "None Provided" on R&S page * Fixing the alert shown when an approver requests action on a report and then goes back to view that report again. * Random test fixes * Fixing "this/the" typo * Improving LandingMessage message when submitting an approver review * Fixing display of "none provided" for regional/state selector on R&S page * Adding missing error messages * Updating error messages * Updates to Review tests * More updates to Review test * Preserve error state during navigation for CR and AR * Fixing a couple random tests for code coverage * Adding supp info test for correct rendering * More test fixes --------- Co-authored-by: Krys Wisnaskas <[email protected]>
elainaparrish
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy