[TTAHUB-5247] Enforce approved Jira issue link on PRs via CI check by kryswisnaskas · Pull Request #3662 · HHS/Head-Start-TTADP

kryswisnaskas · 2026-05-29T20:28:31Z

Description of change

Adds a CI workflow and validation script that fails PRs to main missing a valid TTAHUB-NNNN key in the Issue(s) section of the PR body.

How to test

Open a draft PR and check the "PR Jira Task Link" workflow in the Actions tab. Verify it fails with a clear message when the placeholder TTAHUB-0 is left in or the section is missing, and passes when a real TTAHUB-NNNN key is present.

Issue(s)

https://jira.acf.gov/browse/TTAHUB-5247

Checklists

Every PR

Linked approved Jira issue
JIRA issue status updated
Code is meaningfully tested
[n/a] Meets accessibility standards (WCAG 2.1 Levels A, AA)
API Documentation updated
[n/a] Boundary diagram updated
[n/a] Logical Data Model updated
[n/a] Architectural Decision Records written for major infrastructure decisions
[n/a] UI review complete
QA review complete

Before merge to main

[n/a] OHS demo complete
Ready to create production PR

Bumps [fast-xml-builder](https://github.com/NaturalIntelligence/fast-xml-builder) from 1.1.5 to 1.2.0. - [Changelog](https://github.com/NaturalIntelligence/fast-xml-builder/blob/main/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-builder@v1.1.5...v1.2.0) --- updated-dependencies: - dependency-name: fast-xml-builder dependency-version: 1.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Copilot

Pull request overview

This PR adds a GitHub Actions CI check (plus a small Node validator + unit tests) to enforce that every non-production pull request includes at least one approved Jira issue link (https://jira.acf.gov/browse/TTAHUB-####) in the PR body’s Jira Issue(s) section, and updates the PR template + engineering docs to reflect the new requirement.

Changes:

Add a new PR Jira Issue Link workflow that validates the PR body on key PR events (opened/edited/synchronize/etc.).
Introduce a validator module + CLI wrapper to extract and validate the Jira Issue(s) section and provide actionable failure messages.
Update the PR template, Slack notification workflow parsing, and engineering process documentation to use/recognize the Jira Issue(s) heading.

Impact assessment:

Benefits: Medium (improves traceability and process compliance with clear contributor feedback).
Risks: Medium (new enforcement gate can block PRs; current implementation has a confirmed false-fail scenario that will affect normal template usage).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`tools/validate-pr-jira-issue-link.js`	CLI entrypoint to validate PR body from `PR_BODY` env var.
`tools/pr-jira-issue-link.js`	Core parsing/validation logic for Jira Issue(s) section and URLs.
`tools/pr-jira-issue-link.test.js`	Unit tests covering pass/fail cases and backward-compatible headings.
`docs/guides/engineering-process.md`	Updates process guidance to require a dedicated Jira issue for every PR.
`.github/workflows/pr-notifications.yml`	Adjusts “Issue” section extraction to also match “Jira Issue”.
`.github/workflows/pr-jira-issue-link.yml`	New CI workflow enforcing the Jira link requirement.
`.github/pull_request_template.md`	Renames Issue(s) section to Jira Issue(s) and updates checklist language.

tommaroh · 2026-05-29T23:46:22Z

Might be better to parse this out of the title rather than the body, that is how the Jira integration works

github-actions · 2026-06-01T21:18:49Z

⚠️ Review count advisory: 1 of 2 required human approvals. 1 more needed. Current approvers: thewatermethod.

github-actions · 2026-06-01T21:18:50Z

✅ Diff size: 292 lines — within the 500-line guideline.

kryswisnaskas · 2026-06-01T21:28:04Z

Might be better to parse this out of the title rather than the body, that is how the Jira integration works

I considered parsing from the title, but kept it in the PR body to stay consistent with the current template and existing automation, which already read Jira links from the PR body. It also supports linking multiple Jira issues in a more explicit way.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

thewatermethod

I confirmed that this functions as intended

Worth noting that any link will pass, I used TTAHUB-1234. So there is no "validity" check happening.

kryswisnaskas · 2026-06-03T20:43:08Z

Worth noting that any link will pass, I used TTAHUB-1234. So there is no "validity" check happening.

I think that’s right. This check only makes sure the PR has a Jira style link in the right section. It does not check whether the Jira issue actually exists or is the right one. In this case, TTAHUB-1234 happens to be a different ticket in Done status. I’ll update the wording so it matches what the check really does. If we want real Jira validation, that could be separate follow-up work.

github-actions · 2026-06-04T15:12:46Z

📊 Review Metrics

Auto-generated by the PR Review Metrics workflow. Observe-only — no action required.

Metric	Value
PR Status	✅ Merged
Reviewer Count	1
Reviewers	@thewatermethod
First-Review Turnaround	19.5 hr
Total Review Events	1

Review Timeline

State	Reviewer	Submitted At
✅ APPROVED	@thewatermethod	2026-06-02 17:35 UTC

…3662) * Bump fast-xml-builder from 1.1.5 to 1.2.0 Bumps [fast-xml-builder](https://github.com/NaturalIntelligence/fast-xml-builder) from 1.1.5 to 1.2.0. - [Changelog](https://github.com/NaturalIntelligence/fast-xml-builder/blob/main/CHANGELOG.md) - [Commits](NaturalIntelligence/fast-xml-builder@v1.1.5...v1.2.0) --- updated-dependencies: - dependency-name: fast-xml-builder dependency-version: 1.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * [TTAHUB-5247] Enforce a Jira issue link on PRs via CI check * [TTAHUB-5247] Address PR feedback on Jira issue link validation * [TTAHUB-5247] Soften Jira issue link wording --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dependabot Bot and others added 13 commits May 8, 2026 19:27

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

41c91fc

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

342270f

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

a62c429

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

8ae2bb7

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

7016a1c

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

2f9926e

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

d646a3e

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

e76ab80

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

cf71581

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

6fc4d8d

Merge remote-tracking branch 'origin/main' into kw/ttahub-5247

73d6bf3

[TTAHUB-5247] Enforce a Jira issue link on PRs via CI check

67ceab1

Copilot AI review requested due to automatic review settings May 29, 2026 20:28

Copilot started reviewing on behalf of kryswisnaskas May 29, 2026 20:28 View session

kryswisnaskas marked this pull request as draft May 29, 2026 20:28

Copilot AI reviewed May 29, 2026

View reviewed changes

Comment thread tools/pr-jira-issue-link.js Outdated

Comment thread tools/pr-jira-issue-link.js

Comment thread .github/workflows/pr-jira-issue-link.yml

Comment thread tools/pr-jira-issue-link.test.js

kryswisnaskas added 2 commits June 1, 2026 12:30

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

e639e05

[TTAHUB-5247] Address PR feedback on Jira issue link validation

cd2a4fd

kryswisnaskas added 2 commits June 1, 2026 17:29

Merge branch 'main' of https://github.com/HHS/Head-Start-TTADP

dc9c625

Merge branch 'main' into kw/ttahub-5247

3052fab

kryswisnaskas requested a review from Copilot June 1, 2026 21:31

Copilot started reviewing on behalf of kryswisnaskas June 1, 2026 21:31 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread .github/workflows/pr-jira-issue-link.yml

kryswisnaskas requested review from Andrew565 and tommaroh June 1, 2026 22:03

kryswisnaskas requested review from AdamAdHocTeam, fbonds, hardwarehuman and thewatermethod June 1, 2026 22:03

kryswisnaskas marked this pull request as ready for review June 1, 2026 22:04

kryswisnaskas changed the title ~~Enforce approved Jira issue link on PRs via CI check~~ [TTAHUB-5247] Enforce approved Jira issue link on PRs via CI check Jun 1, 2026

thewatermethod approved these changes Jun 2, 2026

View reviewed changes

[TTAHUB-5247] Soften Jira issue link wording

2b2c7f0

kryswisnaskas added this pull request to the merge queue Jun 4, 2026

Merged via the queue into main with commit 22b98cb Jun 4, 2026
13 checks passed

kryswisnaskas deleted the kw/ttahub-5247 branch June 4, 2026 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TTAHUB-5247] Enforce approved Jira issue link on PRs via CI check#3662

[TTAHUB-5247] Enforce approved Jira issue link on PRs via CI check#3662
kryswisnaskas merged 18 commits into
mainfrom
kw/ttahub-5247

kryswisnaskas commented May 29, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommaroh commented May 29, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 1, 2026 •

edited

Loading

Uh oh!

kryswisnaskas commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

thewatermethod left a comment

Uh oh!

kryswisnaskas commented Jun 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

kryswisnaskas commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

How to test

Issue(s)

Checklists

Every PR

Before merge to main

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tommaroh commented May 29, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kryswisnaskas commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

thewatermethod left a comment

Choose a reason for hiding this comment

Uh oh!

kryswisnaskas commented Jun 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026

📊 Review Metrics

Review Timeline

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kryswisnaskas commented May 29, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading

github-actions Bot commented Jun 1, 2026 •

edited

Loading