Fix for disappearing goals on RTTAPA

[thewatermethod]

Description of change

Race condition meant goal form loaded without objectives. This caused objectives to be erroneously deleted by an overly permissive backend service. A migration here restores the objective we know were deleted erroneously. We may need a follow on PR to revive the deleted ones, if that is possible.

How to test

Load up an existing goal on the RTTAPA with objectives. Note that all objectives on the RTTAPA load on the edit form. Add an objective. Save. Note that all existing objectives appear on the RTTAPA (we aren't down to one)

Jira Issue(s)

• https://jira.acf.gov/browse/TTAHUB-5470

Checklists

Every PR

• Linked Jira issue
• JIRA issue status updated
• Code is meaningfully tested
• Meets accessibility standards (WCAG 2.1 Levels A, AA)
• API Documentation updated
• Boundary diagram updated
• Logical Data Model updated
• Architectural Decision Records written for major infrastructure decisions
• UI review complete
• QA review complete

Before merge to main

• OHS demo complete
• Ready to create production PR

Production Deploy

• PR created as Draft
• Staging smoke test completed
• PR transitioned to Open (this ready_for_review transition triggers the Slack/Jira automation)
• Reviewer added after the PR is Open (elainaparrish is the authorized approver under normal circumstances)
  • Sequence: Draft PR → Smoke test → Open PR (automation runs) → Add reviewer
  • Confirm that the Slack notification was sent after the PR was opened
  • Confirm that linked Jira ticket(s) transitioned as expected; if not, review the GitHub Actions workflow logs

After merge/deploy

• Update JIRA ticket status

[Copilot]

Pull request overview

This PR addresses a race condition on the RTTAPA standard goal edit flow where objectives could fail to load into the form, leading the backend update service to delete objectives that were omitted from the payload. It also includes a corrective migration intended to undelete objectives that were wrongly soft-deleted.

Changes:

• Backend: tighten objective deletion during updateExistingStandardGoal to only remove non-report objectives created via RTR.
• Data repair: add a migration to undelete standard-goal objectives that are still referenced by non-deleted activity reports.
• Frontend: refactor Update/Restart goal pages to mount the form only after the goal is loaded, and add a test to ensure objectives populate on initial render.

Impact assessment

• Benefits: High (prevents data loss and restores impacted data for standard goals/objectives).
• Risks: Medium (changes deletion semantics and includes a production data-repair migration; should be reviewed carefully before merge/deploy).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/services/standardGoals.ts	Restricts objective deletions during standard goal updates to safer subsets (RTR-created, not on any report).
src/services/standardGoal.test.js	Updates test setup for createdVia and adds cleanup to keep tests isolated.
src/migrations/20260621225954-revert-bad-objective-deletions.js	Undeletes Objectives that are still referenced by non-deleted activity reports for standard goal templates.
frontend/src/pages/StandardGoalForm/UpdateStandardGoalForm.js	New component that initializes the form with the fetched goal’s objectives/root causes.
frontend/src/pages/StandardGoalForm/UpdateStandardGoal.js	Refactors page to fetch the goal first, then render the new form component.
frontend/src/pages/StandardGoalForm/RestartStandardGoalForm.js	New component for restart flow, keeping form initialization local to the form.
frontend/src/pages/StandardGoalForm/RestartStandardGoal.js	Refactors restart page to fetch goal first, then render the new restart form component.
frontend/src/pages/StandardGoalForm/tests/UpdateStandardGoal.js	Adds coverage to verify objectives are populated into the update form on initial render.