feat: update disabled tooltips of agreement tabs#5575
Merged
Conversation
weimiao67
requested review from
Santi-3rd,
fpigeonjr,
johndeange,
josbell and
rajohnson90
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the disabled-tab tooltip copy/layout on the Agreement details tabs to better match the intended Figma designs (Issue #5545).
Changes:
- Shortened the “Award & Modifications” disabled tooltip copy.
- Adjusted the “Documents” disabled tooltip to include an explicit line break.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fpigeonjr
approved these changes
Apr 23, 2026
Contributor
fpigeonjr
left a comment
fpigeonjr
left a comment
There was a problem hiding this comment.
Review Summary
This PR updates disabled tooltip copy for two agreement detail tabs to match Figma designs:
Changes:
- Award & Modifications: Shortened to "Award & Modifications tab is coming soon"
- Documents: Updated with explicit line break for better readability
Assessment:
- Low-risk, copy-only changes with no functional code modifications
- All 31+ CI checks passing including unit tests, E2E tests, and a11y regression gate
- Existing tests validate disabled tab behavior appropriately
- Visual result matches screenshots provided in PR description
Approved – straightforward UI copy update ready to merge.
Review submitted on behalf of @fpigeonjr
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jonnalley
approved these changes
Apr 24, 2026
Contributor
|
🎉 This PR is included in version 1.371.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updated disabled tooltips of Award & Modifications and Documents
Issue
#5545
How to test
The tooltip layout should match Figma
A11y impact
A11Y-SUPPRESSIONmetadata (owner, expires, rationale)Screenshots
Definition of Done Checklist